[fix/chore] fix bug in tf det eval script / update dep version specifier by felixdittrich92 · Pull Request #1232 · mindee/doctr (original) (raw)
Navigation Menu
Appearance settings
- AI CODE CREATION
* GitHub CopilotWrite better code with AI
* GitHub Copilot appDirect agents from issue to merge
* MCP RegistryNewIntegrate external tools - DEVELOPER WORKFLOWS
* ActionsAutomate any workflow
* CodespacesInstant dev environments
* IssuesPlan and track work
* Code ReviewManage code changes - APPLICATION SECURITY
* GitHub Advanced SecurityFind and fix vulnerabilities
* Code securitySecure your code as you build
* Secret protectionStop leaks before they start - EXPLORE
* Why GitHub
* Documentation
* Blog
* Changelog
* Marketplace
- AI CODE CREATION
- BY COMPANY SIZE
* Enterprises
* Small and medium teams
* Startups
* Nonprofits - BY USE CASE
* App Modernization
* DevSecOps
* DevOps
* CI/CD
* View all use cases - BY INDUSTRY
* Healthcare
* Financial services
* Manufacturing
* Government
* View all industries
- BY COMPANY SIZE
- EXPLORE BY TOPIC
* AI
* Software Development
* DevOps
* Security
* View all topics - EXPLORE BY TYPE
* Customer stories
* Events & webinars
* Ebooks & reports
* Business insights
* GitHub Skills - SUPPORT & SERVICES
* Documentation
* Customer support
* Community forum
* Trust center
* Partners
- EXPLORE BY TOPIC
- COMMUNITY
* GitHub SponsorsFund open source developers - PROGRAMS
* Security Lab
* Maintainer Community
* Accelerator
* GitHub Stars
* Archive Program - REPOSITORIES
* Topics
* Trending
* Collections
- COMMUNITY
- Pricing
Provide feedback
We read every piece of feedback, and take your input very seriously.
Include my email address so I can be contacted
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Notifications You must be signed in to change notification settings
Additional navigation options
Merged
merged 1 commit into
mindee:mainfrom
felixdittrich92:fix-script-dep-identifier
Jun 27, 2023
ConversationCommits (1)ChecksFiles changed
Merged
[fix/chore] fix bug in tf det eval script / update dep version specifier#1232
merged 1 commit into
mindee:mainfrom
felixdittrich92:fix-script-dep-identifier
Conversation
felixdittrich92 commented
Copy link Copy Markdown
Collaborator
This PR:
- fix minor bug in det eval script
- set upper bound for rapidfuzz to avoid lib breaks again
- update hf hub lib to 0.5.0 (to follow with our python < 3.8 non support)
[fix minor bug in tf eval script and update version identifier](/mindee/doctr/pull/1232/commits/fac2364e4e3f664cd1bae63979f3e71435b4ca9a "fix minor bug in tf eval script and update version identifier")
[fac2364](/mindee/doctr/pull/1232/commits/fac2364e4e3f664cd1bae63979f3e71435b4ca9a)
felixdittrich92 self-assigned this
felixdittrich92 added type: bug
Something isn't working
Related to references folder
framework: tensorflow topic: text detection
Related to the task of text detection
labels
felixdittrich92 added this to the 0.6.1 milestone
felixdittrich92 requested review fromcharlesmindee, frgfm and odulcy-mindee
codecov Bot commented
Copy link Copy Markdown
Codecov Report
Merging #1232 (fac2364) into main (b4b613a) will decrease coverage by
0.23%.
The diff coverage is60.37%.
@@ Coverage Diff @@ ## main #1232 +/- ##
Coverage 93.55% 93.32% -0.23%
Files 154 154
Lines 6915 6924 +9- Hits 6469 6462 -7
- Misses 446 462 +16
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 93.32% <60.37%> (-0.23%) | ⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| doctr/models/detection/linknet/tensorflow.py | 94.89% <ø> (ø) | |
| doctr/models/recognition/parseq/tensorflow.py | 71.11% <60.37%> (-5.75%) | ⬇️ |
... and 2 files with indirect coverage changes
odulcy-mindee approved these changes Jun 27, 2023
felixdittrich92 merged commit b6db82f into mindee:main
felixdittrich92 deleted the fix-script-dep-identifier branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
frgfm Awaiting requested review from frgfm
charlesmindee Awaiting requested review from charlesmindee
1 more reviewer
odulcy-mindee odulcy-mindee approved these changes
Reviewers whose approvals may not affect merge requirements
Assignees
Labels
Related to references folder
Related to the task of text detection
Something isn't working
Projects
None yet
Milestone
Development
Successfully merging this pull request may close these issues.