[fix/chore] fix bug in tf det eval script / update dep version specifier by felixdittrich92 · Pull Request #1232 · mindee/doctr (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

mindee / doctr Public

Additional navigation options

Merged

felixdittrich92

merged 1 commit into

mindee:mainfrom

felixdittrich92:fix-script-dep-identifier

Jun 27, 2023

ConversationCommits (1)ChecksFiles changed

Merged

[fix/chore] fix bug in tf det eval script / update dep version specifier#1232

felixdittrich92

merged 1 commit into

mindee:mainfrom

felixdittrich92:fix-script-dep-identifier

Conversation

@felixdittrich92

@felixdittrich92 felixdittrich92 commented

Jun 27, 2023

Copy link Copy Markdown

Collaborator

This PR:

@felixdittrich92

[fix minor bug in tf eval script and update version identifier](/mindee/doctr/pull/1232/commits/fac2364e4e3f664cd1bae63979f3e71435b4ca9a "fix minor bug in tf eval script and update version identifier")

[fac2364](/mindee/doctr/pull/1232/commits/fac2364e4e3f664cd1bae63979f3e71435b4ca9a)

@felixdittrich92 felixdittrich92 self-assigned this

Jun 27, 2023

@felixdittrich92 felixdittrich92 added type: bug

Something isn't working

ext: references

Related to references folder

framework: tensorflow topic: text detection

Related to the task of text detection

labels

Jun 27, 2023

@felixdittrich92 felixdittrich92 added this to the 0.6.1 milestone

Jun 27, 2023

@felixdittrich92 felixdittrich92 requested review fromcharlesmindee, frgfm and odulcy-mindee

June 27, 2023 11:06

@codecov

codecov Bot commented

Jun 27, 2023

Copy link Copy Markdown

Codecov Report

Merging #1232 (fac2364) into main (b4b613a) will decrease coverage by 0.23%.
The diff coverage is 60.37%.

@@ Coverage Diff @@ ## main #1232 +/- ##

Flag Coverage Δ
unittests 93.32% <60.37%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/detection/linknet/tensorflow.py 94.89% <ø> (ø)
doctr/models/recognition/parseq/tensorflow.py 71.11% <60.37%> (-5.75%) ⬇️

... and 2 files with indirect coverage changes

odulcy-mindee

odulcy-mindee approved these changes Jun 27, 2023

View reviewed changes

@felixdittrich92 felixdittrich92 merged commit b6db82f into mindee:main

Jun 27, 2023

@felixdittrich92 felixdittrich92 deleted the fix-script-dep-identifier branch

June 27, 2023 11:33

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@frgfm frgfm Awaiting requested review from frgfm

@charlesmindee charlesmindee Awaiting requested review from charlesmindee

1 more reviewer

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@felixdittrich92 felixdittrich92

Labels

ext: references

Related to references folder

topic: text detection

Related to the task of text detection

type: bug

Something isn't working

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@felixdittrich92 @odulcy-mindee