[chore]: Replace `tensorflow_addons` by felixdittrich92 · Pull Request #1252 · mindee/doctr (original) (raw)

replaces tensorflow_addons which is end of life (May 2024) --> TensorFlow Addons Wind Down tensorflow/addons#2807
add hotfix for docs build
maybe some space for improvements

Any feedback is welcome :)

[replace rotation](/mindee/doctr/pull/1252/commits/b258f742d2ce907eefb4f437613d6d3ceaf45cd4 "replace rotation")

[b258f74](/mindee/doctr/pull/1252/commits/b258f742d2ce907eefb4f437613d6d3ceaf45cd4)

felixdittrich92 self-assigned this

Jul 17, 2023

felixdittrich92 added module: transforms

Related to doctr.transforms

framework: tensorflow topic: build

Related to dependencies and build

type: misc

Miscellaneous

labels

Jul 17, 2023

felixdittrich92 added this to the 0.6.1 milestone

Jul 17, 2023

codecov Bot commented

Jul 17, 2023

•

edited

Copy link Copy Markdown

Codecov Report

Merging #1252 (732766c) into main (4e1985f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## main #1252 +/- ##

Coverage 95.64% 95.66% +0.01%
Files 154 154
Lines 6873 6903 +30
Hits 6574 6604 +30
Misses 299 299

Flag	Coverage Δ
unittests	95.66% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
doctr/models/classification/vit/tensorflow.py	100.00% <ø> (ø)
doctr/models/recognition/master/tensorflow.py	98.21% <ø> (ø)
doctr/transforms/functional/tensorflow.py	100.00% <100.00%> (ø)
doctr/transforms/modules/tensorflow.py	83.33% <100.00%> (-0.19%)	⬇️

... and 2 files with indirect coverage changes

[minor update](/mindee/doctr/pull/1252/commits/67bd8690820070b7e82aa40b0ee4ad907b7b3b30 "minor update")

[67bd869](/mindee/doctr/pull/1252/commits/67bd8690820070b7e82aa40b0ee4ad907b7b3b30)

felixdittrich92 requested review fromcharlesmindee, frgfm and odulcy-mindee

July 17, 2023 13:13

felixdittrich92 added 2 commits

July 17, 2023 15:15

[trigger CI](/mindee/doctr/pull/1252/commits/406b2a5fec5d64efd592c132715f49aed9d2ca86 "trigger CI")

[406b2a5](/mindee/doctr/pull/1252/commits/406b2a5fec5d64efd592c132715f49aed9d2ca86)

[docs hotfix](/mindee/doctr/pull/1252/commits/0b7a1f430b7702c77a0b415f5ebaf3ec7d38f8d6 "docs hotfix")

[0b7a1f4](/mindee/doctr/pull/1252/commits/0b7a1f430b7702c77a0b415f5ebaf3ec7d38f8d6)

felixdittrich92 marked this pull request as ready for review

July 17, 2023 14:03

odulcy-mindee reviewed Jul 17, 2023

View reviewed changes

Comment thread

doctr/models/classification/vit/tensorflow.py Outdated

[apply suggestion](/mindee/doctr/pull/1252/commits/74681d011a4963ebff7da4ce17d243987f904790 "apply suggestion")

[74681d0](/mindee/doctr/pull/1252/commits/74681d011a4963ebff7da4ce17d243987f904790)

felixdittrich92 requested a review from odulcy-mindee

July 17, 2023 20:11

[np instead random](/mindee/doctr/pull/1252/commits/4afa59ecdf6ead011e57def5f6c9b7c32d23d11e "np instead random")

[4afa59e](/mindee/doctr/pull/1252/commits/4afa59ecdf6ead011e57def5f6c9b7c32d23d11e)

odulcy-mindee reviewed Jul 18, 2023

View reviewed changes

Comment thread

doctr/transforms/modules/tensorflow.py Outdated

felixdittrich92 added 2 commits

July 18, 2023 10:35

[apply suggestions](/mindee/doctr/pull/1252/commits/fe635af8261d20c4f7b9d4d9b509a87e63926326 "apply suggestions")

[fe635af](/mindee/doctr/pull/1252/commits/fe635af8261d20c4f7b9d4d9b509a87e63926326)

[update](/mindee/doctr/pull/1252/commits/732766ce6ffef649e44ba9403862401443f1510e "update")

[732766c](/mindee/doctr/pull/1252/commits/732766ce6ffef649e44ba9403862401443f1510e)

felixdittrich92 requested a review from odulcy-mindee

July 18, 2023 08:41

felixdittrich92 commented

Jul 20, 2023

Copy link Copy Markdown

Collaborator Author

@odulcy-mindee wdyt ? :)

odulcy-mindee approved these changes Jul 20, 2023

View reviewed changes

felixdittrich92 merged commit 1ad033e into mindee:main

Jul 20, 2023

felixdittrich92 deleted the tensorflow-addons-replacement branch

July 20, 2023 12:16

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})