[PyPi] Fix image display by felixdittrich92 · Pull Request #1268 · mindee/doctr (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

mindee / doctr Public

Additional navigation options

Merged

felixdittrich92

merged 1 commit into

mindee:mainfrom

felixdittrich92:pypi-image-display

Jul 26, 2023

ConversationCommits (1)ChecksFiles changed

Merged

[PyPi] Fix image display#1268

felixdittrich92

merged 1 commit into

mindee:mainfrom

felixdittrich92:pypi-image-display

Conversation

@felixdittrich92

@felixdittrich92 felixdittrich92 commented

Jul 24, 2023

edited

Loading

Copy link Copy Markdown

Collaborator

This PR:

#783

@felixdittrich92

[update link](/mindee/doctr/pull/1268/commits/293afc96cc63e62de6bd1eaf835491a308bcecf8 "update link")

[293afc9](/mindee/doctr/pull/1268/commits/293afc96cc63e62de6bd1eaf835491a308bcecf8)

@felixdittrich92 felixdittrich92 added topic: documentation

Improvements or additions to documentation

type: misc

Miscellaneous

labels

Jul 24, 2023

@felixdittrich92 felixdittrich92 added this to the 0.7.0 milestone

Jul 24, 2023

@felixdittrich92 felixdittrich92 requested a review from odulcy-mindee

July 24, 2023 13:20

@felixdittrich92 felixdittrich92 self-assigned this

Jul 24, 2023

@felixT2K

felixT2K commented

Jul 25, 2023

Copy link Copy Markdown

Contributor

@odulcy-mindee Another option would be that you upload the images on your file server and we replace the urls.

odulcy-mindee

odulcy-mindee approved these changes Jul 25, 2023

View reviewed changes

@odulcy-mindee odulcy-mindee left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixdittrich92 it's good enough, thanks for the fix!

@felixdittrich92 felixdittrich92 merged commit 0a47726 into mindee:main

Jul 26, 2023

@felixdittrich92 felixdittrich92 deleted the pypi-image-display branch

July 26, 2023 03:58

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@odulcy-mindee odulcy-mindee odulcy-mindee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@felixdittrich92 felixdittrich92

Labels

topic: documentation

Improvements or additions to documentation

type: misc

Miscellaneous

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@felixdittrich92 @felixT2K @odulcy-mindee