[chore] update to new torchvision API in models as well by felixT2K · Pull Request #1291 · mindee/doctr (original) (raw)

Skip to content

Appearance settings

- AI CODE CREATION
  * GitHub CopilotWrite better code with AI
  * GitHub Copilot appDirect agents from issue to merge
  * MCP RegistryNewIntegrate external tools
- DEVELOPER WORKFLOWS
  * ActionsAutomate any workflow
  * CodespacesInstant dev environments
  * IssuesPlan and track work
  * Code ReviewManage code changes
- APPLICATION SECURITY
  * GitHub Advanced SecurityFind and fix vulnerabilities
  * Code securitySecure your code as you build
  * Secret protectionStop leaks before they start
- EXPLORE
  * Why GitHub
  * Documentation
  * Blog
  * Changelog
  * Marketplace

View all features

- BY COMPANY SIZE
  * Enterprises
  * Small and medium teams
  * Startups
  * Nonprofits
- BY USE CASE
  * App Modernization
  * DevSecOps
  * DevOps
  * CI/CD
  * View all use cases
- BY INDUSTRY
  * Healthcare
  * Financial services
  * Manufacturing
  * Government
  * View all industries

View all solutions

- EXPLORE BY TOPIC
  * AI
  * Software Development
  * DevOps
  * Security
  * View all topics
- EXPLORE BY TYPE
  * Customer stories
  * Events & webinars
  * Ebooks & reports
  * Business insights
  * GitHub Skills
- SUPPORT & SERVICES
  * Documentation
  * Customer support
  * Community forum
  * Trust center
  * Partners

View all resources

- COMMUNITY
  * GitHub SponsorsFund open source developers
- PROGRAMS
  * Security Lab
  * Maintainer Community
  * Accelerator
  * GitHub Stars
  * Archive Program
- REPOSITORIES
  * Topics
  * Trending
  * Collections
- ENTERPRISE SOLUTIONS
  * Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  * GitHub Advanced SecurityEnterprise-grade security features
  * Copilot for BusinessEnterprise-grade AI features
  * Premium SupportEnterprise-grade 24/7 support
Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

mindee / doctr Public

Notifications You must be signed in to change notification settings
Fork650
Star 6.1k
Code
Issues 27
Pull requests 2
Discussions
Actions
Projects
Wiki
Security and quality
Insights

Additional navigation options

Merged

felixdittrich92

merged 1 commit into

mindee:mainfrom

felixT2K:fix-torchvision-warnings

Aug 28, 2023

Conversation Commits (1)Checks Files changed

Merged

[chore] update to new torchvision API in models as well#1291

felixdittrich92

merged 1 commit into

mindee:mainfrom

felixT2K:fix-torchvision-warnings

Conversation

@felixT2K felixT2K commented

•

edited

Loading

Copy link Copy Markdown

Contributor

This PR:

same as done for object detection update to new torchvision API

[update to new torchvision API as well](/mindee/doctr/pull/1291/commits/a7e324eb951aeb6713d77c77f349aabc79eba961 "update to new torchvision API as well")

[a7e324e](/mindee/doctr/pull/1291/commits/a7e324eb951aeb6713d77c77f349aabc79eba961)

felixdittrich92 self-assigned this

felixdittrich92 added this to the 0.7.0 milestone

felixdittrich92 added module: models

Related to doctr.models

framework: pytorch

Related to PyTorch backend

Miscellaneous

labels

felixdittrich92 requested a review from odulcy-mindee

August 28, 2023 12:06

felixT2K changed the title~~[chore] update to new torchvision API as well~~ [chore] update to new torchvision API in models as well

codecov Bot commented

Copy link Copy Markdown

Codecov Report

Merging #1291 (a7e324e) into main (3deac68) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## main #1291 +/- ##

Coverage 95.78% 95.78% -0.01%
Files 154 154
Lines 6903 6902 -1
Hits 6612 6611 -1
Misses 291 291

Flag	Coverage Δ
unittests	95.78% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
doctr/models/classification/mobilenet/pytorch.py	100.00% <100.00%> (ø)
doctr/models/classification/resnet/pytorch.py	100.00% <100.00%> (ø)
doctr/models/classification/vgg/pytorch.py	100.00% <100.00%> (ø)
...s/detection/differentiable_binarization/pytorch.py	97.77% <100.00%> (-0.02%)	⬇️

... and 1 file with indirect coverage changes

odulcy-mindee approved these changes Aug 28, 2023

View reviewed changes

felixdittrich92 merged commit 1f0169b into mindee:main

felixT2K deleted the fix-torchvision-warnings branch

August 28, 2023 12:33

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

odulcy-mindee odulcy-mindee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

felixdittrich92

Labels

framework: pytorch

Related to PyTorch backend

Related to doctr.models

Miscellaneous

Projects

None yet

Milestone

Development

Successfully merging this pull request may close these issues.

3 participants