[Fix] imgur5k test by felixdittrich92 · Pull Request #903 · mindee/doctr (original) (raw)

felixdittrich92 commented

Apr 28, 2022

•

edited

Loading

Copy link Copy Markdown

Collaborator

This PR fixes the failing imgur5k test:

• inconsistent number of boxes samples yields to different numbers of samples in the test
• now each sample has the same number of boxes to avoid random numbers of samples (recognition test)

felixdittrich92 added 29 commits

January 11, 2022 08:34

[backup](/mindee/doctr/pull/903/commits/81c313eb7b759bb3c4c6e33547408d2bf3de7771 "backup")

[81c313e](/mindee/doctr/pull/903/commits/81c313eb7b759bb3c4c6e33547408d2bf3de7771)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/50574b591c400dcec64c31c8891170695abdb6df "Merge branch 'mindee:main' into main")

[50574b5](/mindee/doctr/pull/903/commits/50574b591c400dcec64c31c8891170695abdb6df)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/5a6ed546227327617d24ebddce40c122091afaf2 "Merge branch 'mindee:main' into main")

[5a6ed54](/mindee/doctr/pull/903/commits/5a6ed546227327617d24ebddce40c122091afaf2)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/b9958a7e02aa646134c9c581b3ffc6d611a387ac "Merge branch 'mindee:main' into main")

[b9958a7](/mindee/doctr/pull/903/commits/b9958a7e02aa646134c9c581b3ffc6d611a387ac)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/14c4651a750fa9cd696248b40e080bad74696790 "Merge branch 'mindee:main' into main")

[14c4651](/mindee/doctr/pull/903/commits/14c4651a750fa9cd696248b40e080bad74696790)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/779731fe3dba5454873bb5c2ffb5565f3a5941b8 "Merge branch 'mindee:main' into main")

[779731f](/mindee/doctr/pull/903/commits/779731fe3dba5454873bb5c2ffb5565f3a5941b8)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/ce2cdda8166bfc8ef31afec3248b37891f721a5f "Merge branch 'mindee:main' into main")

[ce2cdda](/mindee/doctr/pull/903/commits/ce2cdda8166bfc8ef31afec3248b37891f721a5f)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/d13dc43e1d7845f3a71f81777b915c9e2f1b1f61 "Merge branch 'mindee:main' into main")

[d13dc43](/mindee/doctr/pull/903/commits/d13dc43e1d7845f3a71f81777b915c9e2f1b1f61)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/9a07d73a8de1a4a66f1e0836593173e779c9af63 "Merge branch 'mindee:main' into main")

[9a07d73](/mindee/doctr/pull/903/commits/9a07d73a8de1a4a66f1e0836593173e779c9af63)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/a002a7068d418a3d8fb69a77f9d432024ed331bd "Merge branch 'mindee:main' into main")

[a002a70](/mindee/doctr/pull/903/commits/a002a7068d418a3d8fb69a77f9d432024ed331bd)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/6ad096e04a4f04da8c0b23c5ea27f9ca06883357 "Merge branch 'mindee:main' into main")

[6ad096e](/mindee/doctr/pull/903/commits/6ad096e04a4f04da8c0b23c5ea27f9ca06883357)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/1e77fd422fb93359a0f821be58f3e9842ad3f432 "Merge branch 'mindee:main' into main")

[1e77fd4](/mindee/doctr/pull/903/commits/1e77fd422fb93359a0f821be58f3e9842ad3f432)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/2be762c1bafff83e6e8efa87e47ebaef46f932a3 "Merge branch 'mindee:main' into main")

[2be762c](/mindee/doctr/pull/903/commits/2be762c1bafff83e6e8efa87e47ebaef46f932a3)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/e2f205519e92674968020a9e37fcb102f17d441b "Merge branch 'mindee:main' into main")

[e2f2055](/mindee/doctr/pull/903/commits/e2f205519e92674968020a9e37fcb102f17d441b)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/bdc4e67f726efce63db5774de18b88470b000dc1 "Merge branch 'mindee:main' into main")

[bdc4e67](/mindee/doctr/pull/903/commits/bdc4e67f726efce63db5774de18b88470b000dc1)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/b525021f613f1c3011bf4fd4935065776c575f75 "Merge branch 'mindee:main' into main")

[b525021](/mindee/doctr/pull/903/commits/b525021f613f1c3011bf4fd4935065776c575f75)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/417a27b0768ca4cad77e0363fcf44db0c614f9cd "Merge branch 'mindee:main' into main")

[417a27b](/mindee/doctr/pull/903/commits/417a27b0768ca4cad77e0363fcf44db0c614f9cd)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/9b3f5a1e23f39c5c6a72e4ee471894151d2a5b2e "Merge branch 'mindee:main' into main")

[9b3f5a1](/mindee/doctr/pull/903/commits/9b3f5a1e23f39c5c6a72e4ee471894151d2a5b2e)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/93074a8d3f78c0aa095ff86ad5245bfa95ba3eda "Merge branch 'mindee:main' into main")

[93074a8](/mindee/doctr/pull/903/commits/93074a8d3f78c0aa095ff86ad5245bfa95ba3eda)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/c64e2094b80937a0a61e80a35540715a35b7506a "Merge branch 'mindee:main' into main")

[c64e209](/mindee/doctr/pull/903/commits/c64e2094b80937a0a61e80a35540715a35b7506a)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/fdc8381cf93665d97eb3508b35c3de89566693a9 "Merge branch 'mindee:main' into main")

[fdc8381](/mindee/doctr/pull/903/commits/fdc8381cf93665d97eb3508b35c3de89566693a9)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/bd68b0732130f1f437f44111afca49dbc98645f9 "Merge branch 'mindee:main' into main")

[bd68b07](/mindee/doctr/pull/903/commits/bd68b0732130f1f437f44111afca49dbc98645f9)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/7ac6ee2647848f66ff7b40e7c077f6b412c51fd7 "Merge branch 'mindee:main' into main")

[7ac6ee2](/mindee/doctr/pull/903/commits/7ac6ee2647848f66ff7b40e7c077f6b412c51fd7)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/1c79f32ae609b5944feaebe38c7e92079a283dee "Merge branch 'mindee:main' into main")

[1c79f32](/mindee/doctr/pull/903/commits/1c79f32ae609b5944feaebe38c7e92079a283dee)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/45e43acdf5198bfaee34a0654e8f52ab562cbf8a "Merge branch 'mindee:main' into main")

[45e43ac](/mindee/doctr/pull/903/commits/45e43acdf5198bfaee34a0654e8f52ab562cbf8a)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/53ba4b92728ea6e28bb22e33c79f4612911a3987 "Merge branch 'mindee:main' into main")

[53ba4b9](/mindee/doctr/pull/903/commits/53ba4b92728ea6e28bb22e33c79f4612911a3987)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/96b597c70da6a4c2fe71c393c9d1b4a82db476af "Merge branch 'mindee:main' into main")

[96b597c](/mindee/doctr/pull/903/commits/96b597c70da6a4c2fe71c393c9d1b4a82db476af)

[Merge branch 'mindee:main' into main](/mindee/doctr/pull/903/commits/cfd13c522a086ba57bb0ec4b891c3a5d3ae9e2e7 "Merge branch 'mindee:main' into main")

[cfd13c5](/mindee/doctr/pull/903/commits/cfd13c522a086ba57bb0ec4b891c3a5d3ae9e2e7)

[fix](/mindee/doctr/pull/903/commits/99e7129dce17d77681c9b113cf0aafd8625c07cf "fix")

[99e7129](/mindee/doctr/pull/903/commits/99e7129dce17d77681c9b113cf0aafd8625c07cf)

felixdittrich92 marked this pull request as draft

April 28, 2022 11:44

[fix-test](/mindee/doctr/pull/903/commits/f76fdefe1646e14fa1c91c1afc3d06dedecbf6bb "fix-test")

[f76fdef](/mindee/doctr/pull/903/commits/f76fdefe1646e14fa1c91c1afc3d06dedecbf6bb)

felixdittrich92 changed the title[Fix] imgur-5k test [Fix] imgur5k test

Apr 28, 2022

felixdittrich92 added 2 commits

April 28, 2022 14:16

[fix-conftest](/mindee/doctr/pull/903/commits/403a87a4624ac3e8d0766091aafa61813b53d317 "fix-conftest")

[403a87a](/mindee/doctr/pull/903/commits/403a87a4624ac3e8d0766091aafa61813b53d317)

[flake](/mindee/doctr/pull/903/commits/debf4f477939686043c8bb913e4cc4bbfef65ef3 "flake")

[debf4f4](/mindee/doctr/pull/903/commits/debf4f477939686043c8bb913e4cc4bbfef65ef3)

codecov Bot commented

Apr 28, 2022

•

edited

Loading

Copy link Copy Markdown

Codecov Report

Merging #903 (debf4f4) into main (56b914c) will increase coverage by 0.02%.
The diff coverage is 95.65%.

@@ Coverage Diff @@ ## main #903 +/- ##

• Coverage 94.70% 94.73% +0.02%

  Files 133 134 +1
  Lines 5442 5465 +23

• Hits 5154 5177 +23
  Misses 288 288

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a1912...debf4f4. Read the comment docs.

felixdittrich92 marked this pull request as ready for review

April 28, 2022 12:35

felixdittrich92 commented

Apr 28, 2022

Copy link Copy Markdown

Collaborator Author

@charlesmindee

charlesmindee approved these changes Apr 28, 2022

View reviewed changes

charlesmindee left a comment

Copy link Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

charlesmindee merged commit dc35d40 into mindee:main

Apr 28, 2022

felixdittrich92 deleted the fix-test branch

April 28, 2022 13:30

felixdittrich92 added type: bug

Something isn't working

ext: tests

Related to tests folder

module: datasets

Related to doctr.datasets

labels

May 2, 2022

felixdittrich92 added this to the 0.6.0 milestone

Jun 29, 2022

felixdittrich92 mentioned this pull request

Jun 29, 2022

Release tracker - v0.6.0#791

Closed

85 tasks

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})