[Fix] MJSynth dataset: filter corrupted or missing images by felixdittrich92 路 Pull Request #956 路 mindee/doctr (original) (raw)

@felixdittrich92

@felixdittrich92 felixdittrich92 commented

Jun 20, 2022

Copy link Copy Markdown

Collaborator

This PR:

Any feedback is welcome 馃

Please merge #954 before this one :)

felixdittrich92 added 2 commits

June 20, 2022 10:50

@felixdittrich92

[filter corrupted or missing images](/mindee/doctr/pull/956/commits/598b8d2803ae9923c8c235dc45f9d569789890a6 "filter corrupted or missing images")

[598b8d2](/mindee/doctr/pull/956/commits/598b8d2803ae9923c8c235dc45f9d569789890a6)

@felixdittrich92

[rename black_list to blacklist](/mindee/doctr/pull/956/commits/417b794f5a9c4dee4403a3887d55b7bcfbe85fa1 "rename black_list to blacklist")

[417b794](/mindee/doctr/pull/956/commits/417b794f5a9c4dee4403a3887d55b7bcfbe85fa1)

@felixdittrich92 felixdittrich92 self-assigned this

Jun 20, 2022

@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone

Jun 20, 2022

@felixdittrich92 felixdittrich92 added type: bug

Something isn't working

module: datasets

Related to doctr.datasets

labels

Jun 20, 2022

@felixdittrich92 felixdittrich92 requested review fromcharlesmindee and frgfm

June 20, 2022 08:54

@felixdittrich92 felixdittrich92 mentioned this pull request

Jun 20, 2022

[datasets] Filter currupted and wrong annotated files in ready to use datasets#935

Closed

23 tasks

@felixdittrich92

[fix constant naming](/mindee/doctr/pull/956/commits/93e9400dfa15a8d9c8081326ee6e3dca5f3da325 "fix constant naming")

[93e9400](/mindee/doctr/pull/956/commits/93e9400dfa15a8d9c8081326ee6e3dca5f3da325)

@codecov

codecov Bot commented

Jun 20, 2022

Copy link Copy Markdown

Codecov Report

Merging #956 (93e9400) into main (210ecc4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## main #956 +/- ##

Flag Coverage 螖
unittests 94.82% <100.00%> (-0.02%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
doctr/datasets/mjsynth.py 95.83% <100.00%> (+0.37%) 猬嗭笍
doctr/transforms/functional/base.py 95.65% <0.00%> (-1.45%) 猬囷笍
doctr/transforms/modules/base.py 94.59% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 210ecc4...93e9400. Read the comment docs.

@frgfm frgfm modified the milestones:0.6.0, 0.5.2

Jun 23, 2022

frgfm

frgfm approved these changes Jun 23, 2022

View reviewed changes

@frgfm frgfm left a comment

Copy link Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix :)

@felixdittrich92 felixdittrich92 merged commit fc90306 into mindee:main

Jun 24, 2022

@felixdittrich92 felixdittrich92 deleted the fix-mjsynth branch

June 24, 2022 02:56

@frgfm frgfm mentioned this pull request

Jun 28, 2022

Release tracker - v0.5.2#967

Closed

14 tasks

@felixdittrich92 felixdittrich92 mentioned this pull request

Sep 26, 2022

Release tracker - v0.6.0#791

Closed

85 tasks

@felixdittrich92 felixdittrich92 modified the milestones:0.5.2, 0.6.0

Sep 26, 2022

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})