docs: Documentation the reason for keras version specifier by frgfm · Pull Request #958 · mindee/doctr (original) (raw)
frgfm commented
Copy link Copy Markdown
Collaborator
This PR simply adds a reference to the reason behind the keras version specifier.
Any feedback is welcome!
cf #932
[docs: Documentation the reason for keras version specifier](/mindee/doctr/pull/958/commits/774ec3d22c2134e572814e50070e0fb8cb739683 "docs: Documentation the reason for keras version specifier")
[774ec3d](/mindee/doctr/pull/958/commits/774ec3d22c2134e572814e50070e0fb8cb739683)
frgfm added topic: documentation
Improvements or additions to documentation
Related to dependencies and build
framework: tensorflow labels
frgfm added this to the 0.5.2 milestone
frgfm self-assigned this
codecov Bot commented
Copy link Copy Markdown
Codecov Report
Merging #958 (774ec3d) into main (c681273) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #958 +/- ##
Coverage 94.83% 94.83%
Files 134 134
Lines 5539 5539
Hits 5253 5253
Misses 286 286
| Flag | Coverage Δ |
|---|---|
| unittests | 94.83% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ |
|---|---|
| doctr/transforms/modules/base.py | 94.59% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update c681273...774ec3d. Read the comment docs.
frgfm requested review fromcharlesmindee and felixdittrich92
felixdittrich92 approved these changes Jun 23, 2022
felixdittrich92 left a comment
Copy link Copy Markdown
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thaaanks :)
felixdittrich92 merged commit b3d2cf4 into main
github-actions Bot commented
Copy link Copy Markdown
Hey @felixdittrich92 👋
You merged this PR, but it is not correctly labeled. The list of valid labels is available at https://github.com/mindee/doctr/blob/main/.github/verify_pr_labels.py
frgfm deleted the dep-ref branch
frgfm added the type: misc
Miscellaneous
label
frgfm mentioned this pull request
Closed
14 tasks
felixdittrich92 mentioned this pull request
Closed
85 tasks
felixdittrich92 modified the milestones:0.5.2, 0.6.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})