[code-infra] Migrate to vite from webpack for e2e tests by brijeshb42 · Pull Request #48248 · mui/material-ui (original) (raw)
added the scope: code-infra
Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).
label
LukasTy added a commit to LukasTy/material-ui that referenced this pull request
test/tsconfig.json used moduleResolution: nodenext, which can't
resolve subpath exports like @mui/material/themeCssVarsAugmentation
the way the Vite/vitest bundler does. That mismatch forced a
brandingThemeShim.{d.ts,js} indirection so MarketingWrapper could
import the docs branding theme without the typecheck choking on its
module augmentations.
Resolve modules like a bundler instead (matching the root tsconfig and the actual regression bundle), then:
- delete both
brandingThemeShimfiles, - import
BrandingProviderdirectly from@mui/internal-core-docs/brandinginMarketingWrapper, - drop the now-needless shim exclude from
test/tsconfig.json.
The nodenext setting predates this PR (added in mui#48248); flipping it
to bundler changes how the whole test/ package typechecks (e2e,
integration, regressions). Verified pnpm typescript (all 19 projects)
and pnpm test:regressions:build still pass.
Addresses a review comment from @Janpot.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})