feat: add Nextclade_pango column to metadata by ivan-aksamentov · Pull Request #291 · nextstrain/ncov-ingest (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

View all resources

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

nextstrain / ncov-ingest Public

Additional navigation options

Merged

ivan-aksamentov

merged 3 commits into

masterfrom

feat/nextclade-pango

Mar 20, 2022

ConversationCommits (3)ChecksFiles changed

Merged

feat: add Nextclade_pango column to metadata#291

ivan-aksamentov

merged 3 commits into

masterfrom

feat/nextclade-pango

Conversation

@ivan-aksamentov

@ivan-aksamentov ivan-aksamentov commented

Mar 15, 2022

edited

Loading

Copy link Copy Markdown

Member

Copies the new Nextclade_pango column from nextclade.tsv to metadata.tsv. This column contains Pango lineages assigned using Nextclade.

Symmetrical PR in ncov: nextstrain/ncov#892

@ivan-aksamentov

[feat: add Nextclade_pango column to metadata](/nextstrain/ncov-ingest/pull/291/commits/940fe5803100648121ee32df56c3a88d7d6605df "feat: add Nextclade_pango column to metadata")

[940fe58](/nextstrain/ncov-ingest/pull/291/commits/940fe5803100648121ee32df56c3a88d7d6605df)

@ivan-aksamentov ivan-aksamentov mentioned this pull request

Mar 15, 2022

feat: add Nextclade_pango column to metadatanextstrain/ncov#892

Merged

4 tasks

@ivan-aksamentov ivan-aksamentov marked this pull request as draft

March 15, 2022 14:10

corneliusroemer

corneliusroemer approved these changes Mar 15, 2022

View reviewed changes

@corneliusroemer

corneliusroemer commented

Mar 15, 2022

Copy link Copy Markdown

Member

Did CI checks fail because we don't yet have Nextclade_pango in nextclade.tsv? @ivan-aksamentov

@ivan-aksamentov

ivan-aksamentov commented

Mar 15, 2022

edited

Loading

Copy link Copy Markdown

Member Author

@corneliusroemer Yes, I think so. The usual ingest full run checklist need to be executed first and then the daily ingest will be able to produce nextclade.tsv and metadata.tsv with the new cloumn.

Let's track it on Slack
https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1647353315650509

corneliusroemer reacted with thumbs up emoji

ivan-aksamentov added 2 commits

March 16, 2022 20:37

@ivan-aksamentov

[Merge remote-tracking branch 'origin/master' into feat/nextclade-pango](/nextstrain/ncov-ingest/pull/291/commits/423926a08c0aea9cbc0dc83c9adfb0895278736b "Merge remote-tracking branch 'origin/master' into feat/nextclade-pango")

[423926a](/nextstrain/ncov-ingest/pull/291/commits/423926a08c0aea9cbc0dc83c9adfb0895278736b)

@ivan-aksamentov

[Merge remote-tracking branch 'origin/master' into feat/nextclade-pango](/nextstrain/ncov-ingest/pull/291/commits/d90ae7b533878fe623e5bda689512f4b064f9bda "Merge remote-tracking branch 'origin/master' into feat/nextclade-pango")

[d90ae7b](/nextstrain/ncov-ingest/pull/291/commits/d90ae7b533878fe623e5bda689512f4b064f9bda)

@ivan-aksamentov ivan-aksamentov marked this pull request as ready for review

March 20, 2022 09:42

@ivan-aksamentov ivan-aksamentov merged commit 76ee829 into master

Mar 20, 2022

@ivan-aksamentov ivan-aksamentov deleted the feat/nextclade-pango branch

March 20, 2022 09:42

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@corneliusroemer corneliusroemer corneliusroemer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects

Nextstrain planning (archived)

Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivan-aksamentov @corneliusroemer