deps: V8: cherry-pick 5b0510d · nodejs/node@0217194 (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Commit 0217194

addaleaxrefack

authored and

committed

deps: V8: cherry-pick 5b0510d

Original commit message: Give the implementation of v8::MicrotaskQueue::New This adds the entrypoint to MicrotaskQueue, which used to miss the implementation. Bug: v8:8124 Change-Id: I114fb69d975ee75c86b19349ca76789e425ea910 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505232 Reviewed-by: Yang Guo yangguo@chromium.org Commit-Queue: Taiju Tsuiki tzik@chromium.org Cr-Commit-Position: refs/heads/master@{#60076} Refs: v8/v8@5b0510dPR-URL: #26685Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Refael Ackermann refack@gmail.com

File tree

3 files changed

lines changed

3 files changed

lines changed

Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@
37 37
38 38 # Reset this number to 0 on major V8 upgrades.
39 39 # Increment by one for each non-official patch applied to deps/v8.
40 -'v8_embedder_string': '-node.3',
40 +'v8_embedder_string': '-node.4',
41 41
42 42 ##### V8 defaults for Node.js #####
43 43
Original file line number Diff line number Diff line change
@@ -6779,7 +6779,7 @@ class V8_EXPORT MicrotaskQueue {
6779 6779 /**
6780 6780 * Creates an empty MicrotaskQueue instance.
6781 6781 */
6782 -static std::unique_ptr New();
6782 +static std::unique_ptr New(Isolate* isolate);
6783 6783
6784 6784 virtual ~MicrotaskQueue() = default;
6785 6785
Original file line number Diff line number Diff line change
@@ -8931,6 +8931,11 @@ void v8::Isolate::LocaleConfigurationChangeNotification() {
8931 8931 #endif // V8_INTL_SUPPORT
8932 8932 }
8933 8933
8934 +// static
8935 +std::unique_ptr MicrotaskQueue::New(Isolate* isolate) {
8936 +return i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate));
8937 +}
8938 +
8934 8939 MicrotasksScope::MicrotasksScope(Isolate* isolate, MicrotasksScope::Type type)
8935 8940 : MicrotasksScope(
8936 8941 isolate,