test: fix postmortem metadata test · nodejs/node@8712edf (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Commit 8712edf

test: fix postmortem metadata test

Recent changes to spawnSync (#23027) broke our V8 postmortem tests since the output from nm was larger than the new default maxBuffer for spawnSync. Changing the maxBuffer to Infinity fixes the issue. PR-URL: #27265Refs: v8/v8@7.4.288.18...7.4.288.21Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

File tree

1 file changed

lines changed

1 file changed

lines changed

Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ if (common.isAIX)
21 21 if (common.isOpenBSD)
22 22 common.skip('no v8 debug symbols on OpenBSD');
23 23
24 -const nm = spawnSync('nm', args);
24 +const nm = spawnSync('nm', args, { maxBuffer: Infinity });
25 25
26 26 if (nm.error && nm.error.errno === 'ENOENT')
27 27 common.skip('nm not found on system');