src: remove icuDataDir from node config · nodejs/node@9021b0d (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Commit 9021b0d

GauthamBanasandraTrott

authored and

committed

src: remove icuDataDir from node config

icuDataDir seems to be redundant as it is not used anywhere. Hence removing it. PR-URL: #24780Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Steven R Loomis srloomis@us.ibm.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

File tree

1 file changed

lines changed

1 file changed

lines changed

Original file line number Diff line number Diff line change
@@ -49,10 +49,6 @@ static void Initialize(Local target,
49 49 READONLY_TRUE_PROPERTY(target, "hasNodeOptions");
50 50 #endif
51 51
52 -// TODO(addaleax): This seems to be an unused, private API. Remove it?
53 -READONLY_STRING_PROPERTY(target, "icuDataDir",
54 - per_process_opts->icu_data_dir);
55 -
56 52 #endif // NODE_HAVE_I18N_SUPPORT
57 53
58 54 if (env->options()->preserve_symlinks)