deps: use nghttp2's config.h on all platforms · nodejs/node@90cf2d5 (original) (raw)
Navigation Menu
- Explore
- Pricing
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Commit 90cf2d5
deps: use nghttp2's config.h on all platforms
Fix warnings about use of htonl(), etc. by including config.h for all platforms, defining HAVE_ARPA_INET_H on non-Windows, and therefore including <arpa/inet.h>, which defines the host to network byte order conversion functions. PR-URL: #27283Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Refael Ackermann refack@gmail.com
File tree
2 files changed
lines changed
2 files changed
lines changed
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -54,7 +54,9 @@ typedef intptr_t ssize_t; | ||
| 54 | 54 | /* #undef NOTHREADS */ |
| 55 | 55 | |
| 56 | 56 | /* Define to 1 if you have the <arpa/inet.h> header file. */ |
| 57 | -/* #undef HAVE_ARPA_INET_H */ | |
| 57 | +#ifndef _WIN32 | |
| 58 | +# define HAVE_ARPA_INET_H 1 | |
| 59 | +#endif | |
| 58 | 60 | |
| 59 | 61 | /* Define to 1 if you have the <fcntl.h> header file. */ |
| 60 | 62 | #define HAVE_FCNTL_H 1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -12,13 +12,13 @@ | ||
| 12 | 12 | 'defines': [ |
| 13 | 13 | 'BUILDING_NGHTTP2', |
| 14 | 14 | 'NGHTTP2_STATICLIB', |
| 15 | +'HAVE_CONFIG_H', | |
| 15 | 16 | ], |
| 16 | 17 | 'conditions': [ |
| 17 | 18 | ['OS=="win"', { |
| 18 | 19 | 'defines': [ |
| 19 | 20 | 'WIN32', |
| 20 | 21 | '_WINDOWS', |
| 21 | -'HAVE_CONFIG_H', | |
| 22 | 22 | ], |
| 23 | 23 | 'msvs_settings': { |
| 24 | 24 | 'VCCLCompilerTool': { |