src: make model counter in GetCPUInfo() unsigned · nodejs/node@b0089a5 (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Commit b0089a5

src: make model counter in GetCPUInfo() unsigned

This fixes a compiler warning about comparing against the (unsigned) `NODE_PUSH_VAL_TO_ARRAY_MAX` constant. PR-URL: #23880Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Sam Roberts vieuxtech@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Eugene Ostroukhov eostroukhov@google.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Matheus Marchini mat@mmarchini.me

File tree

1 file changed

lines changed

1 file changed

lines changed

Original file line number Diff line number Diff line change
@@ -168,7 +168,7 @@ static void GetCPUInfo(const FunctionCallbackInfo& args) {
168 168 Local cpus = args[2].As();
169 169
170 170 Local model_argv[NODE_PUSH_VAL_TO_ARRAY_MAX];
171 -int model_idx = 0;
171 +unsigned int model_idx = 0;
172 172
173 173 for (i = 0, field_idx = 0; i < count; i++) {
174 174 uv_cpu_info_t* ci = cpu_infos + i;