deps: V8: cherry-pick 7803fa6 · nodejs/node@cec35a5 (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Commit cec35a5

jkunkeetargos

authored and

committed

deps: V8: cherry-pick 7803fa6

Original commit message: Move ARM64 Assembler::nop definition from header to source file When Assembler::nop is in the header, it is considered an inline function. With GN arg is_component_build=true, the V8_EXPORT_PRIVATE mark on the class causes it to be exported every time the header is included. This, in turn, produces a reference to Register::XRegFromCode. Register::XRegFromCode is only ever defined as an inlined function, so that reference is never fulfilled. Clang can avoid this using the /Fc:dllexportInlines- flag to suppress the export of Assembler::nop and so avoid generating the reference to Register::XRegFromCode. MSVC does not support this flag, so this change suppresses the export by moving Assembler::nop's definition to the .cc file. This also allows it to use the inline definition of Register::XRegFromCode. Bug: v8:8870 Change-Id: I1cd33195677256c9dd06c7047fe84e1b912d3151 Reviewed-on: https://chromium-review.googlesource.com/c/1478216 Reviewed-by: Jakob Gruber jgruber@chromium.org Commit-Queue: Michael Achenbach machenbach@chromium.org Cr-Commit-Position: refs/heads/master@{#59785} Refs: v8/v8@7803fa6PR-URL: #25852Reviewed-By: Ujjwal Sharma usharma1998@gmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Ali Ijaz Sheikh ofrobots@google.com

File tree

1 file changed

lines changed

1 file changed

lines changed

Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@
37 37
38 38 # Reset this number to 0 on major V8 upgrades.
39 39 # Increment by one for each non-official patch applied to deps/v8.
40 -'v8_embedder_string': '-node.5',
40 +'v8_embedder_string': '-node.6',
41 41
42 42 ##### V8 defaults for Node.js #####
43 43