path: iojs@1.6.0 breaks compatibility with previous versions · Issue #1215 · nodejs/node (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

In iojs 1.5.1:

path.dirname(undefined) '.'

path.dirname([ 'sup/dude' ]) 'sup'

In iojs 1.6.0:

path.dirname(undefined) TypeError: Path must be a string. Received undefined at assertPath (path.js:8:11) at Object.posix.dirname (path.js:539:3) at repl:1:6 at REPLServer.defaultEval (repl.js:124:27) at bound (domain.js:254:14) at REPLServer.runBound [as eval] (domain.js:267:12) at REPLServer. (repl.js:277:12) at emitOne (events.js:77:13) at REPLServer.emit (events.js:166:7) at REPLServer.Interface._onLine (readline.js:195:10)

path.dirname([ 'sup/dude' ]) TypeError: Path must be a string. Received [ 'sup/dude' ] at assertPath (path.js:8:11) at Object.posix.dirname (path.js:539:3) at repl:1:6 at REPLServer.defaultEval (repl.js:124:27) at bound (domain.js:254:14) at REPLServer.runBound [as eval] (domain.js:267:12) at REPLServer. (repl.js:277:12) at emitOne (events.js:77:13) at REPLServer.emit (events.js:166:7) at REPLServer.Interface._onLine (readline.js:195:10)

This appears to be a bug introduced by this PR: #1153.

This suddenly started causing tests in webtorrent and browserify to start failing. Here's an example.