test: add test for _setSimultaneousAccepts() by melikhov-dev · Pull Request #24180 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Add a test case that verifies that calling the _setSimultaneousAccepts()
function twice does not trigger the deprecation warning twice.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- tests and/or benchmarks are included
- commit message follows commit guidelines
Issues and PRs related to the net subsystem.
Issues and PRs related to the tests.
labels
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
@amel-true Could you undo the merge commit here? Our CI doesn’t play well with them, and we don’t allow merge commits in the master branch. If there were conflicts, using git rebase is the better choice (for this project, at least).
Add a test case that verifies that calling the _setSimultaneousAccepts()
function twice does not trigger the deprecation warning twice.
[commit message was longer than 72 chars, fixed it while landing ]
landed as 3235d31
thank you @amel-true for the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps
gireeshpunathil pushed a commit that referenced this pull request
Add a test case that verifies that calling _setSimultaneousAccepts() function twice does not trigger the deprecation warning twice.
PR-URL: #24180 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request
Add a test case that verifies that calling _setSimultaneousAccepts() function twice does not trigger the deprecation warning twice.
PR-URL: nodejs#24180 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
This was referenced
Apr 23, 2019
Labels
Issues related to the Code-and-Learn events and PRs submitted during the events.
Issues and PRs related to the net subsystem.
Issues and PRs related to the tests.