http2: make Http2ServerResponse#end() always return this by ronag · Pull Request #24346 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Http2Response.end can return false instead of this.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

lpinca changed the title~~Http2 compat end return this~~ http2: Make Http2ServerResponse#end() always return this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

lpinca changed the title~~http2: Make Http2ServerResponse#end() always return this~~ http2: make Http2ServerResponse#end() always return this

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

PR-URL: nodejs#24346 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Colin Ihrig cjihrig@gmail.com

BridgeAR pushed a commit that referenced this pull request

PR-URL: #24346 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Colin Ihrig cjihrig@gmail.com

BridgeAR pushed a commit that referenced this pull request

PR-URL: #24346 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Colin Ihrig cjihrig@gmail.com

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

PR-URL: nodejs#24346 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Colin Ihrig cjihrig@gmail.com

BridgeAR pushed a commit that referenced this pull request

PR-URL: #24346 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Colin Ihrig cjihrig@gmail.com

BethGriggs pushed a commit that referenced this pull request

PR-URL: #24346 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Colin Ihrig cjihrig@gmail.com

This was referenced

May 29, 2019

Labels

PRs that have at least one approval, no pending requests for changes, and a CI started.

Issues or PRs related to the http2 subsystem.