http: add maxHeaderSize property by cjihrig · Pull Request #24860 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Requested by @mcollina in #24811 ~~, but I didn't want to stall that out. Ignore the commits to deps and cli, which are just #24811.~~

This PR exposes the value of --max-http-header-size as a property of the http module.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs/lts would you be ok in backporting this to 6/8/10?

@@ -62,3 +63,16 @@ module.exports = {
get,
request
};

Object.defineProperty(module.exports, 'maxHeaderSize', {
configurable: true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be configurable: false, writeable: false?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writable is not supported on accessor descriptors.

cjihrig added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Dec 20, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

PR-URL: nodejs#24860 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com Reviewed-By: Shelley Vohr codebytere@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

PR-URL: #24860 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com Reviewed-By: Shelley Vohr codebytere@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

Should this be included in the various releases being prepared for 6.x -> 11.x right now?

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request

Dec 25, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

Backport-PR-URL: #25218 PR-URL: #24860 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com Reviewed-By: Shelley Vohr codebytere@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

This was referenced

Dec 25, 2018

MylesBorins added a commit that referenced this pull request

Dec 25, 2018

The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser.

Notable changes:

cli:
- add --max-http-header-size flag (cjihrig) #24811
http:
- add maxHeaderSize property (cjihrig) #24860

PR-URL: #25178

MylesBorins added a commit that referenced this pull request

Dec 25, 2018

The 8.14.0 security release introduced some unexpected breakages on the 8.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser.

Notable changes:

cli:
- add --max-http-header-size flag (cjihrig) #24811
http:
- add maxHeaderSize property (cjihrig) #24860

PR-URL: #25177

MylesBorins added a commit that referenced this pull request

Dec 25, 2018

Notable Changes:

cli:
- add --max-http-header-size flag (cjihrig) #24811
crypto:
- always accept certificates as public keys (Tobias Nießen) #24234
- add key object API (Tobias Nießen) #24234
- update root certificates (Sam Roberts) #25113
deps:
- upgrade to libuv 1.24.1 (cjihrig) #25078
- upgrade npm to 6.5.0 (Audrey Eschright) #24734
http:
- add maxHeaderSize property (cjihrig) #24860

PR-URL: #25175

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018

This commit exposes the value of --max-http-header-size as a property of the http module.

MylesBorins added a commit that referenced this pull request

Dec 26, 2018

Notable Changes:

cli:
- add --max-http-header-size flag (cjihrig) #24811
crypto:
- always accept certificates as public keys (Tobias Nießen) #24234
- add key object API (Tobias Nießen) #24234
- update root certificates (Sam Roberts) #25113
deps:
- upgrade to libuv 1.24.1 (cjihrig) #25078
- upgrade npm to 6.5.0 (Audrey Eschright) #24734
http:
- add maxHeaderSize property (cjihrig) #24860

PR-URL: #25175

MylesBorins added a commit that referenced this pull request

Dec 26, 2018

Notable Changes:

cli:
- add --max-http-header-size flag (cjihrig) #24811
crypto:
- always accept certificates as public keys (Tobias Nießen) #24234
- add key object API (Tobias Nießen) #24234
- update root certificates (Sam Roberts) #25113
deps:
- upgrade to libuv 1.24.1 (cjihrig) #25078
- upgrade npm to 6.5.0 (Audrey Eschright) #24734
http:
- add maxHeaderSize property (cjihrig) #24860

PR-URL: #25175

MylesBorins added a commit that referenced this pull request

Dec 26, 2018

Notable changes:

cli:
- add --max-http-header-size flag (cjihrig) #24811
http:
- add maxHeaderSize property (cjihrig) #24860

PR-URL: #25178

MylesBorins added a commit that referenced this pull request

Dec 26, 2018

Notable changes:

cli:
- add --max-http-header-size flag (cjihrig) #24811
http:
- add maxHeaderSize property (cjihrig) #24860

PR-URL: #25177

MylesBorins added a commit that referenced this pull request

Dec 26, 2018

The 10.14.0 security release introduced some unexpected breakages on the 10.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser.

Notable Changes:

cli:
- add --max-http-header-size flag (cjihrig) #24811
http:
- add maxHeaderSize property (cjihrig) #24860

PR-URL: #25176

MylesBorins added a commit that referenced this pull request

Dec 26, 2018

Notable Changes:

cli:
- add --max-http-header-size flag (cjihrig) #24811
crypto:
- always accept certificates as public keys (Tobias Nießen) #24234
- add key object API (Tobias Nießen) #24234
- update root certificates (Sam Roberts) #25113
deps:
- upgrade to libuv 1.24.1 (cjihrig) #25078
- upgrade npm to 6.5.0 (Audrey Eschright) #24734
http:
- add maxHeaderSize property (cjihrig) #24860