tls: introduce client 'session' event by sam-github · Pull Request #25831 · nodejs/node (original) (raw)
OpenSSL has supported async notification of sessions and tickets since
1.1.0 using SSL_CTX_sess_set_new_cb(), for all versions of TLS. Using
the async API is optional for TLS1.2 and below, but for TLS1.3 it will
be mandatory. Future-proof applications should start to use async
notification immediately. In the future, for TLS1.3, applications that
don't use the async API will silently, but gracefully, fail to resume
sessions and instead do a full handshake.
See: https://wiki.openssl.org/index.php/TLS1.3#Sessions
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- tests and/or benchmarks are included
- documentation is changed or added
- commit message follows commit guidelines
Issues and PRs that require attention from people who are familiar with C++.
Issues and PRs related to general changes in the lib or src directory.
labels
Issues and PRs related to the tls subsystem.
PRs that contain new features and should be released in the next minor version.
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
OpenSSL has supported async notification of sessions and tickets since 1.1.0 using SSL_CTX_sess_set_new_cb(), for all versions of TLS. Using the async API is optional for TLS1.2 and below, but for TLS1.3 it will be mandatory. Future-proof applications should start to use async notification immediately. In the future, for TLS1.3, applications that don't use the async API will silently, but gracefully, fail to resume sessions and instead do a full handshake.
See: https://wiki.openssl.org/index.php/TLS1.3#Sessions
addaleax pushed a commit that referenced this pull request
OpenSSL has supported async notification of sessions and tickets since 1.1.0 using SSL_CTX_sess_set_new_cb(), for all versions of TLS. Using the async API is optional for TLS1.2 and below, but for TLS1.3 it will be mandatory. Future-proof applications should start to use async notification immediately. In the future, for TLS1.3, applications that don't use the async API will silently, but gracefully, fail to resume sessions and instead do a full handshake.
See: https://wiki.openssl.org/index.php/TLS1.3#Sessions
PR-URL: #25831 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Fedor Indutny fedor.indutny@gmail.com
This was referenced
Feb 15, 2019
sam-github added a commit to sam-github/node that referenced this pull request
This introduces TLS1.3 support and makes it the default max protocol, but also supports CLI/NODE_OPTIONS switches to disable it if necessary.
TLS1.3 is a major update to the TLS protocol, with many security enhancements. It should be preferred over TLS1.2 whenever possible.
TLS1.3 is different enough that even though the OpenSSL APIs are technically API/ABI compatible, that when TLS1.3 is negotiated, the timing of protocol records and of callbacks broke assumptions hard-coded into the 'tls' module.
This change introduces no API incompatibilities when TLS1.2 is negotiated. It is the intention that it be backported to current and LTS release lines with the default maximum TLS protocol reset to 'TLSv1.2'. This will allow users of those lines to explicitly enable TLS1.3 if they want.
API incompatibilities between TLS1.2 and TLS1.3 are:
Renegotiation is not supported by TLS1.3 protocol, attempts to call
.renegotiate()will always fail.Compiling against a system OpenSSL lower than 1.1.1 is no longer supported (OpenSSL-1.1.0 used to be supported with configure flags).
Variations of
conn.write('data'); conn.destroy()have undefined behaviour according to the streams API. They may or may not send the 'data', and may or may not cause a ERR_STREAM_DESTROYED error to be emitted. This has always been true, but conditions under which the write suceeds is slightly but observably different when TLS1.3 is negotiated vs when TLS1.2 or below is negotiated.If TLS1.3 is negotiated, and a server calls
conn.end()in its 'secureConnection' listener without any data being written, the client will not receive session tickets (no 'session' events will be emitted, andconn.getSession()will never return a resumable session).The return value of
conn.getSession()API may not return a resumable session if called right after the handshake. The effect will be that clients using the legacygetSession()API will resume sessions if TLS1.2 is negotiated, but will do full handshakes if TLS1.3 is negotiated. See nodejs#25831 for more information.
sam-github added a commit that referenced this pull request
This introduces TLS1.3 support and makes it the default max protocol, but also supports CLI/NODE_OPTIONS switches to disable it if necessary.
TLS1.3 is a major update to the TLS protocol, with many security enhancements. It should be preferred over TLS1.2 whenever possible.
TLS1.3 is different enough that even though the OpenSSL APIs are technically API/ABI compatible, that when TLS1.3 is negotiated, the timing of protocol records and of callbacks broke assumptions hard-coded into the 'tls' module.
This change introduces no API incompatibilities when TLS1.2 is negotiated. It is the intention that it be backported to current and LTS release lines with the default maximum TLS protocol reset to 'TLSv1.2'. This will allow users of those lines to explicitly enable TLS1.3 if they want.
API incompatibilities between TLS1.2 and TLS1.3 are:
Renegotiation is not supported by TLS1.3 protocol, attempts to call
.renegotiate()will always fail.Compiling against a system OpenSSL lower than 1.1.1 is no longer supported (OpenSSL-1.1.0 used to be supported with configure flags).
Variations of
conn.write('data'); conn.destroy()have undefined behaviour according to the streams API. They may or may not send the 'data', and may or may not cause a ERR_STREAM_DESTROYED error to be emitted. This has always been true, but conditions under which the write suceeds is slightly but observably different when TLS1.3 is negotiated vs when TLS1.2 or below is negotiated.If TLS1.3 is negotiated, and a server calls
conn.end()in its 'secureConnection' listener without any data being written, the client will not receive session tickets (no 'session' events will be emitted, andconn.getSession()will never return a resumable session).The return value of
conn.getSession()API may not return a resumable session if called right after the handshake. The effect will be that clients using the legacygetSession()API will resume sessions if TLS1.2 is negotiated, but will do full handshakes if TLS1.3 is negotiated. See #25831 for more information.
PR-URL: #26209 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Rod Vagg rod@vagg.org
sam-github added a commit to sam-github/node that referenced this pull request
This introduces TLS1.3 support and makes it the default max protocol, but also supports CLI/NODE_OPTIONS switches to disable it if necessary.
TLS1.3 is a major update to the TLS protocol, with many security enhancements. It should be preferred over TLS1.2 whenever possible.
TLS1.3 is different enough that even though the OpenSSL APIs are technically API/ABI compatible, that when TLS1.3 is negotiated, the timing of protocol records and of callbacks broke assumptions hard-coded into the 'tls' module.
This change introduces no API incompatibilities when TLS1.2 is negotiated. It is the intention that it be backported to current and LTS release lines with the default maximum TLS protocol reset to 'TLSv1.2'. This will allow users of those lines to explicitly enable TLS1.3 if they want.
API incompatibilities between TLS1.2 and TLS1.3 are:
Renegotiation is not supported by TLS1.3 protocol, attempts to call
.renegotiate()will always fail.Compiling against a system OpenSSL lower than 1.1.1 is no longer supported (OpenSSL-1.1.0 used to be supported with configure flags).
Variations of
conn.write('data'); conn.destroy()have undefined behaviour according to the streams API. They may or may not send the 'data', and may or may not cause a ERR_STREAM_DESTROYED error to be emitted. This has always been true, but conditions under which the write suceeds is slightly but observably different when TLS1.3 is negotiated vs when TLS1.2 or below is negotiated.If TLS1.3 is negotiated, and a server calls
conn.end()in its 'secureConnection' listener without any data being written, the client will not receive session tickets (no 'session' events will be emitted, andconn.getSession()will never return a resumable session).The return value of
conn.getSession()API may not return a resumable session if called right after the handshake. The effect will be that clients using the legacygetSession()API will resume sessions if TLS1.2 is negotiated, but will do full handshakes if TLS1.3 is negotiated. See nodejs#25831 for more information.
PR-URL: nodejs#26209 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Rod Vagg rod@vagg.org
sam-github added a commit to sam-github/node that referenced this pull request
This introduces TLS1.3 support and makes it the default max protocol, but also supports CLI/NODE_OPTIONS switches to disable it if necessary.
TLS1.3 is a major update to the TLS protocol, with many security enhancements. It should be preferred over TLS1.2 whenever possible.
TLS1.3 is different enough that even though the OpenSSL APIs are technically API/ABI compatible, that when TLS1.3 is negotiated, the timing of protocol records and of callbacks broke assumptions hard-coded into the 'tls' module.
This change introduces no API incompatibilities when TLS1.2 is negotiated. It is the intention that it be backported to current and LTS release lines with the default maximum TLS protocol reset to 'TLSv1.2'. This will allow users of those lines to explicitly enable TLS1.3 if they want.
API incompatibilities between TLS1.2 and TLS1.3 are:
Renegotiation is not supported by TLS1.3 protocol, attempts to call
.renegotiate()will always fail.Compiling against a system OpenSSL lower than 1.1.1 is no longer supported (OpenSSL-1.1.0 used to be supported with configure flags).
Variations of
conn.write('data'); conn.destroy()have undefined behaviour according to the streams API. They may or may not send the 'data', and may or may not cause a ERR_STREAM_DESTROYED error to be emitted. This has always been true, but conditions under which the write suceeds is slightly but observably different when TLS1.3 is negotiated vs when TLS1.2 or below is negotiated.If TLS1.3 is negotiated, and a server calls
conn.end()in its 'secureConnection' listener without any data being written, the client will not receive session tickets (no 'session' events will be emitted, andconn.getSession()will never return a resumable session).The return value of
conn.getSession()API may not return a resumable session if called right after the handshake. The effect will be that clients using the legacygetSession()API will resume sessions if TLS1.2 is negotiated, but will do full handshakes if TLS1.3 is negotiated. See nodejs#25831 for more information.
PR-URL: nodejs#26209 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Rod Vagg rod@vagg.org
BethGriggs pushed a commit that referenced this pull request
This introduces TLS1.3 support and makes it the default max protocol, but also supports CLI/NODE_OPTIONS switches to disable it if necessary.
TLS1.3 is a major update to the TLS protocol, with many security enhancements. It should be preferred over TLS1.2 whenever possible.
TLS1.3 is different enough that even though the OpenSSL APIs are technically API/ABI compatible, that when TLS1.3 is negotiated, the timing of protocol records and of callbacks broke assumptions hard-coded into the 'tls' module.
This change introduces no API incompatibilities when TLS1.2 is negotiated. It is the intention that it be backported to current and LTS release lines with the default maximum TLS protocol reset to 'TLSv1.2'. This will allow users of those lines to explicitly enable TLS1.3 if they want.
API incompatibilities between TLS1.2 and TLS1.3 are:
Renegotiation is not supported by TLS1.3 protocol, attempts to call
.renegotiate()will always fail.Compiling against a system OpenSSL lower than 1.1.1 is no longer supported (OpenSSL-1.1.0 used to be supported with configure flags).
Variations of
conn.write('data'); conn.destroy()have undefined behaviour according to the streams API. They may or may not send the 'data', and may or may not cause a ERR_STREAM_DESTROYED error to be emitted. This has always been true, but conditions under which the write suceeds is slightly but observably different when TLS1.3 is negotiated vs when TLS1.2 or below is negotiated.If TLS1.3 is negotiated, and a server calls
conn.end()in its 'secureConnection' listener without any data being written, the client will not receive session tickets (no 'session' events will be emitted, andconn.getSession()will never return a resumable session).The return value of
conn.getSession()API may not return a resumable session if called right after the handshake. The effect will be that clients using the legacygetSession()API will resume sessions if TLS1.2 is negotiated, but will do full handshakes if TLS1.3 is negotiated. See #25831 for more information.
Backport-PR-URL: #26951 PR-URL: #26209 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Rod Vagg rod@vagg.org
sam-github added a commit to sam-github/node that referenced this pull request
OpenSSL has supported async notification of sessions and tickets since 1.1.0 using SSL_CTX_sess_set_new_cb(), for all versions of TLS. Using the async API is optional for TLS1.2 and below, but for TLS1.3 it will be mandatory. Future-proof applications should start to use async notification immediately. In the future, for TLS1.3, applications that don't use the async API will silently, but gracefully, fail to resume sessions and instead do a full handshake.
See: https://wiki.openssl.org/index.php/TLS1.3#Sessions
PR-URL: nodejs#25831 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Fedor Indutny fedor.indutny@gmail.com