src: remove process.binding('config').debugOptions by joyeecheung · Pull Request #25999 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

process.binding('config').debugOptions, which contains the initial
values of parsed debugger-related CLI options, has been used for
internal testing. This patch removes them and uses internal/options
to query the values in the tests instead.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Feb 8, 2019

process.binding('config').debugOptions, which contains the initial values of parsed debugger-related CLI options, has been used for internal testing. This patch removes them and uses internal/options to query the values in the tests instead.

Ping @nodejs/process @addaleax can I have some review please?

CI is green … Should this be labelled dont-land-on-v11.x? Like, is there a chance people have been using this through process.binding('config')?

@addaleax We can label it don't land on v11 on the safe side, although the properties exposed here are not even really useful for non-test use cases as they only capture the parsed CLI options, and are not in sync with the actual state of the process. e.g. if someone wants to know about the port they are more likely to use the documented process.debugPort which also comes with a setter.

pull bot pushed a commit to shakir-abdo/node that referenced this pull request

Feb 19, 2019

process.binding('config').debugOptions, which contains the initial values of parsed debugger-related CLI options, has been used for internal testing. This patch removes them and uses internal/options to query the values in the tests instead.

PR-URL: nodejs#25999 Reviewed-By: Daniel Bevenius daniel.bevenius@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com

This was referenced

Apr 23, 2019

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.