doc: fix deprecation "End-of-Life" capitalization by tniessen · Pull Request #26251 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

There are 78 occurrences of End-of-Life and two occurrences of End-Of-Life.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 21, 2019

Member

@Trott Trott left a comment • Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and agree with @Trott's idea.

LGTM, and agree with @Trott's idea.

Once this lands, I'm happy to do it, but a PR is of course welcome!

I thought it would make the most sense as part of this PR, but yea, it can be separate too.

richardlau added a commit to richardlau/remark-preset-lint-node that referenced this pull request

Feb 22, 2019

BridgeAR pushed a commit to nodejs/remark-preset-lint-node that referenced this pull request

Feb 22, 2019

Trott pushed a commit to Trott/io.js that referenced this pull request

Feb 23, 2019

PR-URL: nodejs#26251 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

Trott added a commit to Trott/io.js that referenced this pull request

Feb 23, 2019

Update remark-preset-lint-node to 1.4.0. This adds End-Of-Life as a prohibited string, favoring End-of-Life for consistency.

Refs: nodejs#26251

Trott mentioned this pull request

Feb 23, 2019

2 tasks

Trott added a commit to Trott/io.js that referenced this pull request

Feb 26, 2019

Update remark-preset-lint-node to 1.4.0. This adds End-Of-Life as a prohibited string, favoring End-of-Life for consistency.

Refs: nodejs#26251

PR-URL: nodejs#26281 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

addaleax pushed a commit that referenced this pull request

Mar 1, 2019

Update remark-preset-lint-node to 1.4.0. This adds End-Of-Life as a prohibited string, favoring End-of-Life for consistency.

Refs: #26251

PR-URL: #26281 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

This was referenced

Apr 23, 2019

This was referenced

Apr 23, 2019

cjihrig added a commit to cjihrig/node that referenced this pull request

Jun 2, 2020