tty: improve color detection by BridgeAR · Pull Request #26264 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

BridgeAR

  1. Using process.env.TERM = 'dumb' should never return any colors.
  2. process.env.TERM = 'terminator' supports 24 bit colors.
  3. Add support for process.env.TERM = 'rxvt-unicode-24bit'
  4. Hyper does not support true colors anymore. It should fall back
    to the xterm settings in regular cases.
  5. process.env.COLORTERM = 'truecolor' should return 24 bit colors.

Refs: #26261

Checklist

@nodejs-github-bot

@BridgeAR sadly an error occured when I tried to trigger a build :(

addaleax

Fishrock123

@BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 28, 2019

@BridgeAR

@BridgeAR

@BridgeAR

@BridgeAR

  1. Using process.env.TERM = 'dumb' should never return any colors.
  2. process.env.TERM = 'terminator' supports 24 bit colors.
  3. Add support for process.env.TERM = 'rxvt-unicode-24bit'
  4. Hyper does not support true colors anymore. It should fall back to the xterm settings in regular cases.
  5. process.env.COLORTERM = 'truecolor' should return 24 bit colors.

@BridgeAR

@richardlau

@BridgeAR

@richardlau

@BridgeAR

@Fishrock123

I am quite frankly surprised that pty even works on AIX...

@BridgeAR

addaleax

jasnell

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Mar 3, 2019

@BridgeAR

PR-URL: nodejs#26264 Refs: nodejs#26261 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com Reviewed-By: James M Snell jasnell@gmail.com

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Mar 3, 2019

@BridgeAR

  1. Using process.env.TERM = 'dumb' should never return any colors.
  2. process.env.TERM = 'terminator' supports 24 bit colors.
  3. Add support for process.env.TERM = 'rxvt-unicode-24bit'
  4. Hyper does not support true colors anymore. It should fall back to the xterm settings in regular cases.
  5. process.env.COLORTERM = 'truecolor' should return 24 bit colors.

PR-URL: nodejs#26264 Refs: nodejs#26261 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com Reviewed-By: James M Snell jasnell@gmail.com

@BridgeAR

BridgeAR added a commit that referenced this pull request

Mar 4, 2019

@BridgeAR

PR-URL: #26264 Refs: #26261 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com Reviewed-By: James M Snell jasnell@gmail.com

BridgeAR added a commit that referenced this pull request

Mar 4, 2019

@BridgeAR

  1. Using process.env.TERM = 'dumb' should never return any colors.
  2. process.env.TERM = 'terminator' supports 24 bit colors.
  3. Add support for process.env.TERM = 'rxvt-unicode-24bit'
  4. Hyper does not support true colors anymore. It should fall back to the xterm settings in regular cases.
  5. process.env.COLORTERM = 'truecolor' should return 24 bit colors.

PR-URL: #26264 Refs: #26261 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com Reviewed-By: James M Snell jasnell@gmail.com

@BridgeAR BridgeAR deleted the improve-color-detection branch

January 20, 2020 11:54

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

tty

Issues and PRs related to the tty subsystem.