src: move AsyncResource impl out of public header by bnoordhuis · Pull Request #26348 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Implementing the methods out-of-line (i.e., not inline) means we can fix
bugs and have already compiled add-ons pick up the fixes automatically,
something that doesn't work when the methods are inline because then
they get compiled into the add-on instead of the node binary.

CI: https://ci.nodejs.org/job/node-test-pull-request/21029/

@bnoordhuis sadly an error occured when I tried to trigger a build :(

nodejs-github-bot added build

Issues and PRs related to build files or the CI.

c++

Issues and PRs that require attention from people who are familiar with C++.

labels

Feb 28, 2019

I don’t quite understand the Windows CI failure (there doesn’t seem to be information about where in our source it is coming from), but it seems related.

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 1, 2019

addaleax removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 2, 2019

Implementing the methods out-of-line (i.e., not inline) means we can fix bugs and have already compiled add-ons pick up the fixes automatically, something that doesn't work when the methods are inline because then they get compiled into the add-on instead of the node binary.

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 25, 2019

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Apr 4, 2019

Implementing the methods out-of-line (i.e., not inline) means we can fix bugs and have already compiled add-ons pick up the fixes automatically, something that doesn't work when the methods are inline because then they get compiled into the add-on instead of the node binary.

PR-URL: nodejs#26348 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

This was referenced

Apr 23, 2019

Reviewers

refack refack approved these changes