tools: windows_boxstarter: "choco install python -y" for Python 3 by cclauss · Pull Request #26424 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation23 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

As suggested at #25789 (comment)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

refack added the windows

Issues and PRs related to the Windows platform.

label

Mar 4, 2019

I would hold with that until all other Python 3 tasks are completed.

Why do people want to wait? Everyone seems to have their favorite fix that they want us to hold off doing until tomorrow. 303 days until Python 2 end of life.

Is there a reason for installing two different versions of Python?

Yes. It is commonly done around the planet. In this instance, it gives our users the ability to test out node running on both Python and legacy Python. It is also done at nodejs/build#1644 on the node build machines and on all Travis CI xenial images.

MacOS: brew install python python@2
Windows: choco install python python2

Most Linux distros already include both Python and legacy Python (if they still ship with Python 2 at all) but just in case, commands like sudo apt install python3.7 python2.7 will work.

IMHO this boxstarter script is for people who just want to be able to install native modules (as it is tied to a checkbox in installer), the "general public", not the developers. I think it should be kept minimal. Unless both Python versions are needed to build Node or native addons, we should stick to installing one version.

bzoz approved these changes Mar 4, 2019

Contributor

@bzoz bzoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case LGTM.

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 5, 2019

@nodejs/python @nodejs/platform-windows @nodejs/build-files @nodejs/tooling PTAL. This could use another review.

Contributor

@bzoz bzoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BridgeAR removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 8, 2019

vsemozhetbyt added the python

PRs and issues that require attention from people who are familiar with Python.

label

Mar 19, 2019

Python 2 will reach its _end-of-life_ at the end of 2019. Afterwards, the
interpreter will not get updates -- no bugfixes, no security fixes, nothing. In
the interim, the Python ecosystem is abandoning 2.7 support.
https://python3statement.org/ In order to remain safe and current the Node.js

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this URL be hidden in a link?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

bzoz approved these changes Mar 19, 2019

@refack, @targos, @rvagg, @mhdawson Your reviews please? We need to get Python 3 onto the build machines and developer sandboxes so we can do complete testing.