url: require encodeStr from internal/querystring by ZYSzys · Pull Request #26538 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

encodeStr function is exported from internal/querystring.js originally.

module.exports = {
encodeStr,
hexTable,
isHexTable
};

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

danbev pushed a commit that referenced this pull request

PR-URL: #26538 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com

ZYSzys deleted the url-encodeStr branch

March 12, 2019 06:00

BridgeAR pushed a commit that referenced this pull request

PR-URL: #26538 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com

BridgeAR pushed a commit that referenced this pull request

PR-URL: #26538 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com

Labels

PRs that have at least one approval, no pending requests for changes, and a CI started.

Issues and PRs related to the legacy built-in url module.