test: fix compiler warning in test_string.c by danbev · Pull Request #26539 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

danbev

Currently, the following compiler warnings is generated:

../test_string.c:235:50: warning: incompatible pointer types passing 'char [1]' to parameter of type 'const char16_t *' (aka 'const unsigned short ') [-Wincompatible-pointer-types] NAPI_CALL(env, napi_create_string_utf16(env, "", ((size_t)INT_MAX) + 1, &output)); ^~ ../../common.h:50:23: note: expanded from macro 'NAPI_CALL' NAPI_CALL_BASE(env, the_call, NULL) ^~~~~~~~ ../../common.h:42:10: note: expanded from macro 'NAPI_CALL_BASE' if ((the_call) != napi_ok) {
^~~~~~~~ /node/src/js_native_api.h:80:66: note: passing argument to parameter 'str' here const char16_t str, ^ 1 warning generated.

This commit adds a cast to silence this warning.

Checklist

@danbev

Currently, the following compiler warnings is generated:

../test_string.c:235:50: warning: incompatible pointer types passing 'char [1]' to parameter of type 'const char16_t *' (aka 'const unsigned short ') [-Wincompatible-pointer-types] NAPI_CALL(env, napi_create_string_utf16(env, "", ((size_t)INT_MAX) + 1, &output)); ^~ ../../common.h:50:23: note: expanded from macro 'NAPI_CALL' NAPI_CALL_BASE(env, the_call, NULL) ^~~~~~~~ ../../common.h:42:10: note: expanded from macro 'NAPI_CALL_BASE' if ((the_call) != napi_ok) {
^~~~~~~~ /node/src/js_native_api.h:80:66: note: passing argument to parameter 'str' here const char16_t str, ^ 1 warning generated.

This commit adds a cast to silence this warning.

@nodejs-github-bot

@danbev

addaleax

richardlau

cjihrig

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 9, 2019

jasnell

@danbev

@danbev danbev deleted the napi_test_string_warning branch

March 12, 2019 05:18

danbev added a commit that referenced this pull request

Mar 12, 2019

@danbev

Currently, the following compiler warnings is generated:

../test_string.c:235:50: warning: incompatible pointer types passing 'char [1]' to parameter of type 'const char16_t *' (aka 'const unsigned short ') [-Wincompatible-pointer-types] NAPI_CALL(env, napi_create_string_utf16(env, "", ((size_t)INT_MAX) + 1, &output)); ^~ ../../common.h:50:23: note: expanded from macro 'NAPI_CALL' NAPI_CALL_BASE(env, the_call, NULL) ^~~~~~~~ ../../common.h:42:10: note: expanded from macro 'NAPI_CALL_BASE' if ((the_call) != napi_ok) {
^~~~~~~~ /node/src/js_native_api.h:80:66: note: passing argument to parameter 'str' here const char16_t str, ^ 1 warning generated.

This commit adds a cast to silence this warning.

PR-URL: #26539 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

BridgeAR pushed a commit that referenced this pull request

Mar 13, 2019

@danbev @BridgeAR

Currently, the following compiler warnings is generated:

../test_string.c:235:50: warning: incompatible pointer types passing 'char [1]' to parameter of type 'const char16_t *' (aka 'const unsigned short ') [-Wincompatible-pointer-types] NAPI_CALL(env, napi_create_string_utf16(env, "", ((size_t)INT_MAX) + 1, &output)); ^~ ../../common.h:50:23: note: expanded from macro 'NAPI_CALL' NAPI_CALL_BASE(env, the_call, NULL) ^~~~~~~~ ../../common.h:42:10: note: expanded from macro 'NAPI_CALL_BASE' if ((the_call) != napi_ok) {
^~~~~~~~ /node/src/js_native_api.h:80:66: note: passing argument to parameter 'str' here const char16_t str, ^ 1 warning generated.

This commit adds a cast to silence this warning.

PR-URL: #26539 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

BridgeAR pushed a commit that referenced this pull request

Mar 14, 2019

@danbev @BridgeAR

Currently, the following compiler warnings is generated:

../test_string.c:235:50: warning: incompatible pointer types passing 'char [1]' to parameter of type 'const char16_t *' (aka 'const unsigned short ') [-Wincompatible-pointer-types] NAPI_CALL(env, napi_create_string_utf16(env, "", ((size_t)INT_MAX) + 1, &output)); ^~ ../../common.h:50:23: note: expanded from macro 'NAPI_CALL' NAPI_CALL_BASE(env, the_call, NULL) ^~~~~~~~ ../../common.h:42:10: note: expanded from macro 'NAPI_CALL_BASE' if ((the_call) != napi_ok) {
^~~~~~~~ /node/src/js_native_api.h:80:66: note: passing argument to parameter 'str' here const char16_t str, ^ 1 warning generated.

This commit adds a cast to silence this warning.

PR-URL: #26539 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

BethGriggs pushed a commit that referenced this pull request

Apr 16, 2019

@danbev @BethGriggs

Currently, the following compiler warnings is generated:

../test_string.c:235:50: warning: incompatible pointer types passing 'char [1]' to parameter of type 'const char16_t *' (aka 'const unsigned short ') [-Wincompatible-pointer-types] NAPI_CALL(env, napi_create_string_utf16(env, "", ((size_t)INT_MAX) + 1, &output)); ^~ ../../common.h:50:23: note: expanded from macro 'NAPI_CALL' NAPI_CALL_BASE(env, the_call, NULL) ^~~~~~~~ ../../common.h:42:10: note: expanded from macro 'NAPI_CALL_BASE' if ((the_call) != napi_ok) {
^~~~~~~~ /node/src/js_native_api.h:80:66: note: passing argument to parameter 'str' here const char16_t str, ^ 1 warning generated.

This commit adds a cast to silence this warning.

PR-URL: #26539 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

This was referenced

May 29, 2019

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

test

Issues and PRs related to the tests.