test: fix syntax error in test-dns-idna2008.js when failing by refack · Pull Request #26570 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Refs: #25870
Refs: #26473

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

refack added dns

Issues and PRs related to the dns subsystem.

test

Issues and PRs related to the tests.

flaky-test

Issues and PRs related to the tests with unstable failures on the CI.

labels

Mar 10, 2019

Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 10, 2019

Actually since right now master is broken, I'd like to fast-track this.
Please 👍 here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention in the commit log the commit that introduced the bug? It's 9613221 "test: de-flake test-dns-idna2008.js", isn't it?

Can you mention in the commit log the commit that introduced the bug

Done.

Fixes a bug I introduced in 9613221

PR-URL: nodejs#26570 Refs: nodejs#25870 Refs: nodejs#26473 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

refack removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

fast-track

PRs that do not need to wait for 48 hours to land.

labels

Mar 12, 2019

refack deleted the fix-idna2008-test++ branch

March 12, 2019 15:16

BridgeAR pushed a commit that referenced this pull request

Mar 13, 2019

Fixes a bug I introduced in 9613221

PR-URL: #26570 Refs: #25870 Refs: #26473 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

BridgeAR pushed a commit that referenced this pull request

Mar 14, 2019

Fixes a bug I introduced in 9613221

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Mar 14, 2019

Fixes a bug I introduced in 9613221

BridgeAR pushed a commit that referenced this pull request

Mar 14, 2019

Fixes a bug I introduced in 9613221

Reviewers

bnoordhuis bnoordhuis approved these changes