[v11.x backport] src: refactor node options parsers to mitigate MSVC bug by refack · Pull Request #26649 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Backport of #26280

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

Issues and PRs related to general changes in the lib or src directory.

v11.x labels

header explicit usage, order, and reduce use of *-inl.h
pointer -> const reference when possible
no variable recyclicng
std::begin/end prefered over instance.begin/end
USE for explicit unused resaults

PR-URL: nodejs#26280 Fixes: nodejs#25593 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

targos pushed a commit that referenced this pull request

Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

targos pushed a commit that referenced this pull request

header explicit usage, order, and reduce use of *-inl.h
pointer -> const reference when possible
no variable recyclicng
std::begin/end prefered over instance.begin/end
USE for explicit unused resaults

Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

targos pushed a commit that referenced this pull request

header explicit usage, order, and reduce use of *-inl.h
pointer -> const reference when possible
no variable recyclicng
std::begin/end prefered over instance.begin/end
USE for explicit unused resaults

Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

refack deleted the backport-26280-to-v11.x branch

April 14, 2019 21:46

Labels

Issues and PRs that require attention from people who are familiar with C++.

Issues and PRs related to general changes in the lib or src directory.