src: fix DTrace GC callbacks DCHECKs and add cleanup by joyeecheung · Pull Request #26742 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

joyeecheung

Use the variant of GC callbacks that takes data to
avoid running into DCHECKs when multiple Environments try to add
the same callback to the same isolate multiple times.
In addition, remove the callbacks in the Environment cleanup hook.

Fixes: #26736

Checklist

@joyeecheung

Use the variant of GC callbacks that takes data to avoid running into DCHECKs when multiple Environments try to add the same callback to the same isolate multiple times. In addition, remove the callbacks in the Environment cleanup hook.

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Mar 18, 2019

@joyeecheung

mmarchini

addaleax

jasnell

@joyeecheung

@danbev

danbev pushed a commit that referenced this pull request

Mar 21, 2019

@joyeecheung @danbev

Use the variant of GC callbacks that takes data to avoid running into DCHECKs when multiple Environments try to add the same callback to the same isolate multiple times. In addition, remove the callbacks in the Environment cleanup hook.

PR-URL: #26742 Fixes: #26736 Reviewed-By: Matheus Marchini mat@mmarchini.me Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com

This was referenced

Apr 23, 2019

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.