child_process: reduce internal usage of public require of util by toshi1127 · Pull Request #26769 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

toshi1127

Remove the usage of public require('util'), as described in issue:
#26546

Checklist

@toshi1127

shisama

@shisama

jasnell

ZYSzys

@ZYSzys ZYSzys added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 22, 2019

BridgeAR

@ZYSzys

ZYSzys pushed a commit that referenced this pull request

Mar 22, 2019

@toshi1127 @ZYSzys

PR-URL: #26769 Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

targos pushed a commit that referenced this pull request

Mar 28, 2019

@toshi1127 @targos

PR-URL: #26769 Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

targos pushed a commit that referenced this pull request

Mar 30, 2019

@toshi1127 @targos

PR-URL: #26769 Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

child_process

Issues and PRs related to the child_process subsystem.