dgram: remove usage of public require('util') by dnlup · Pull Request #26770 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Use require('internal/util').deprecate instead of
require('util').deprecate.

Refs: #26546

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion

Use require('internal/util').deprecate instead of require('util').deprecate.

Refs: nodejs#26546

ZYSzys added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 22, 2019

antsmartian pushed a commit that referenced this pull request

Mar 23, 2019

Use require('internal/util').deprecate instead of require('util').deprecate.

Refs: #26546

PR-URL: #26770 Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

targos pushed a commit to targos/node that referenced this pull request

Mar 27, 2019

Use require('internal/util').deprecate instead of require('util').deprecate.

Refs: nodejs#26546

PR-URL: nodejs#26770 Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

targos pushed a commit that referenced this pull request

Mar 27, 2019

Use require('internal/util').deprecate instead of require('util').deprecate.

Refs: #26546

PR-URL: #26770 Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

dnlup deleted the util_dgram branch

January 10, 2020 13:48

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

dgram

Issues and PRs related to the dgram subsystem / UDP.