test: fix test-console-stdio-setters to test setters by Trott · Pull Request #26796 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

test-console-stdio-setters needs to test against the global console in
order to test the setters for the lazy-loaded _stdout and _stderr
properties.

Debugging shows that the current form of the test doesn't call into the setters (which also show as uncovered in the current coverage report). Using the global console fixes it.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

test-console-stdio-setters needs to test against the global console in order to test the setters for the lazy-loaded _stdout and _stderr properties.

Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 20, 2019

Trott added a commit to Trott/io.js that referenced this pull request

Mar 22, 2019

test-console-stdio-setters needs to test against the global console in order to test the setters for the lazy-loaded _stdout and _stderr properties.

PR-URL: nodejs#26796 Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

targos pushed a commit to targos/node that referenced this pull request

Mar 27, 2019

test-console-stdio-setters needs to test against the global console in order to test the setters for the lazy-loaded _stdout and _stderr properties.

PR-URL: nodejs#26796 Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

targos pushed a commit that referenced this pull request

Mar 27, 2019

test-console-stdio-setters needs to test against the global console in order to test the setters for the lazy-loaded _stdout and _stderr properties.

PR-URL: #26796 Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

BethGriggs pushed a commit that referenced this pull request

Apr 17, 2019

test-console-stdio-setters needs to test against the global console in order to test the setters for the lazy-loaded _stdout and _stderr properties.

PR-URL: #26796 Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

MylesBorins pushed a commit that referenced this pull request

May 16, 2019

test-console-stdio-setters needs to test against the global console in order to test the setters for the lazy-loaded _stdout and _stderr properties.

PR-URL: #26796 Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

This was referenced

May 29, 2019

Trott deleted the fix-console-test branch

January 13, 2022 22:51

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

test

Issues and PRs related to the tests.