node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

sam-github added tls

Issues and PRs related to the tls subsystem.

doc

Issues and PRs related to the documentations.

labels

Mar 20, 2019

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 25, 2019

sam-github added a commit that referenced this pull request

Mar 25, 2019

PR-URL: #26821 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

BethGriggs pushed a commit that referenced this pull request

Mar 26, 2019

IIUC this should land with or after #26951

will cherry pick onto the backport for tls1.3

sam-github added a commit to sam-github/node that referenced this pull request

Apr 1, 2019

PR-URL: nodejs#26821 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

sam-github added a commit to sam-github/node that referenced this pull request

Apr 11, 2019

BethGriggs pushed a commit that referenced this pull request

Apr 15, 2019

Backport-PR-URL: #26951 PR-URL: #26821 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

This was referenced

Apr 23, 2019

This looks like it went out in 11.15.0, so I'm going to change backport-requested-v11.x label for backported-to-v11.x label. Hope that's the right thing to do.

Looks like DEFAULT_MIN_VERSION was in 10.16.0 but no documentation is in 10.16.0 for it. Does this need a v10.x backport? Cherry-pick? Neither? @sam-github @BethGriggs

Trott mentioned this pull request

Jul 18, 2019

(Refs: #28758. That should be closed once this is in 10.x-staging, I suppose.)

@nitinsurana do you have time to backport the 11.x version of this, fa6f0f1, to 10.x? It would be fairly straight-forward, but all references to TLSv1.3 would have to be removed.

I added the various labels, but don't know when this will hit the top of my TODO list.

ckarande added a commit to ckarande/node that referenced this pull request

Jul 23, 2019

Add documentation for tls.DEFAULT_MAX_VERSION and tls.DEFAULT_MIN_VERSION, which existed in v10.6.0

Fixes: nodejs#28758 Refs: nodejs#26821

BethGriggs pushed a commit that referenced this pull request

Oct 7, 2019

Add documentation for tls.DEFAULT_MAX_VERSION and tls.DEFAULT_MIN_VERSION, which existed in v10.6.0

Fixes: #28758 Refs: #26821

PR-URL: #28827 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com

BethGriggs pushed a commit that referenced this pull request

Oct 7, 2019

PR-URL: #28827 Fixes: #28758 Refs: #26821 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

doc

Issues and PRs related to the documentations.

tls

Issues and PRs related to the tls subsystem.