test: complete console.assert() coverage by Trott · Pull Request #26827 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

There is one condition in the console.assert() code that is not
tested currently. Add a test to confirm that console.assert(false)
does not include a : in its output.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

There is one condition in the console.assert() code that is not tested currently. Add a test to confirm that console.assert(false) does not include a : in its output.

Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 20, 2019

Trott added a commit to Trott/io.js that referenced this pull request

Mar 22, 2019

There is one condition in the console.assert() code that is not tested currently. Add a test to confirm that console.assert(false) does not include a : in its output.

PR-URL: nodejs#26827 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

targos pushed a commit to targos/node that referenced this pull request

Mar 27, 2019

There is one condition in the console.assert() code that is not tested currently. Add a test to confirm that console.assert(false) does not include a : in its output.

targos pushed a commit that referenced this pull request

Mar 27, 2019

There is one condition in the console.assert() code that is not tested currently. Add a test to confirm that console.assert(false) does not include a : in its output.

PR-URL: #26827 Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de

BethGriggs pushed a commit that referenced this pull request

Apr 17, 2019

There is one condition in the console.assert() code that is not tested currently. Add a test to confirm that console.assert(false) does not include a : in its output.

MylesBorins pushed a commit that referenced this pull request

May 16, 2019

There is one condition in the console.assert() code that is not tested currently. Add a test to confirm that console.assert(false) does not include a : in its output.