src: micro-optimize ALPN negotiation by bnoordhuis · Pull Request #26836 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

bnoordhuis

99 out of a 100 times (conservative estimate!) the negotiated protocol
will be either "h2" or "http/1.1" so reuse an existing JS string for
those instead of creating a new one every time.

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

labels

Mar 21, 2019

addaleax

jasnell

@bnoordhuis

99 out of a 100 times (conservative estimate!) the negotiated protocol will be either "h2" or "http/1.1" so reuse an existing JS string for those instead of creating a new one every time.

@bnoordhuis

sam-github

cjihrig

@bnoordhuis

@Trott

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 25, 2019

Trott pushed a commit to Trott/io.js that referenced this pull request

Mar 25, 2019

@bnoordhuis @Trott

99 out of a 100 times (conservative estimate!) the negotiated protocol will be either "h2" or "http/1.1" so reuse an existing JS string for those instead of creating a new one every time.

PR-URL: nodejs#26836 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Sam Roberts vieuxtech@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

@Trott

targos pushed a commit to targos/node that referenced this pull request

Mar 27, 2019

@bnoordhuis @targos

99 out of a 100 times (conservative estimate!) the negotiated protocol will be either "h2" or "http/1.1" so reuse an existing JS string for those instead of creating a new one every time.

PR-URL: nodejs#26836 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Sam Roberts vieuxtech@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

targos pushed a commit that referenced this pull request

Mar 27, 2019

@bnoordhuis @targos

99 out of a 100 times (conservative estimate!) the negotiated protocol will be either "h2" or "http/1.1" so reuse an existing JS string for those instead of creating a new one every time.

PR-URL: #26836 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Sam Roberts vieuxtech@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.