doc: fix comma of the list in worker_threads.md by nodejh · Pull Request #26838 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes- tests and/or benchmarks are included
- documentation is changed or added
- commit message follows commit guidelines
Seems fast-trackable. 👍 here if you are a Collaborator and you agree.
Trott added fast-track
PRs that do not need to wait for 48 hours to land.
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
vsemozhetbyt pushed a commit that referenced this pull request
PR-URL: #26838 Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
targos pushed a commit to targos/node that referenced this pull request
PR-URL: nodejs#26838 Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
targos pushed a commit that referenced this pull request
PR-URL: #26838 Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
BethGriggs pushed a commit that referenced this pull request
PR-URL: #26838 Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
MylesBorins pushed a commit that referenced this pull request
PR-URL: #26838 Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Masashi Hirano shisama07@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
This was referenced
May 29, 2019
Reviewers
jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
shisama shisama approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
Labels
PRs that have at least one approval, no pending requests for changes, and a CI started.
Issues and PRs related to the documentations.
PRs that do not need to wait for 48 hours to land.