crypto: rename generateKeyPairEdDSA by tniessen · Pull Request #26900 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore. "NID" is the term OpenSSL uses for numerical representations of OIDs such as EVP_PKEY_X448.

Refs: #26774

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore.

Refs: nodejs#26774

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

labels

Mar 25, 2019

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 25, 2019

publicFormat, publicType,
privateFormat, privateType,
cipher, passphrase, wrap);
impl = (wrap) => generateKeyPairNid(id,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not directly related, but it looks to me that id should be nid.

tniessen added a commit that referenced this pull request

Mar 28, 2019

Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore.

PR-URL: #26900 Refs: #26774 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Sam Roberts vieuxtech@gmail.com

Landed in df1c9eb, thanks for reviewing.

targos pushed a commit that referenced this pull request

Mar 28, 2019

Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore.

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore.

This was referenced

Apr 23, 2019

tniessen removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 14, 2021

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.