build: remove unused label from vcbuild.bat by bnoordhuis · Pull Request #26901 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

bnoordhuis

Remove the :wix-not-found label and harmonize the spelling of "WiX".

@bnoordhuis

Remove the :wix-not-found label and harmonize the spelling of "WiX".

@nodejs-github-bot

cjihrig

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 25, 2019

@nodejs-github-bot

BethGriggs

richardlau

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the goto that referenced :wix-not-found was removed in #16969.

@targos

targos pushed a commit that referenced this pull request

Mar 30, 2019

@bnoordhuis @targos

Remove the :wix-not-found label and harmonize the spelling of "WiX".

PR-URL: #26901 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Richard Lau riclau@uk.ibm.com

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

@bnoordhuis @BethGriggs

Remove the :wix-not-found label and harmonize the spelling of "WiX".

PR-URL: #26901 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Richard Lau riclau@uk.ibm.com

BethGriggs pushed a commit that referenced this pull request

Apr 9, 2019

@bnoordhuis @BethGriggs

Remove the :wix-not-found label and harmonize the spelling of "WiX".

PR-URL: #26901 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Beth Griggs Bethany.Griggs@uk.ibm.com Reviewed-By: Richard Lau riclau@uk.ibm.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

build

Issues and PRs related to build files or the CI.

windows

Issues and PRs related to the Windows platform.