path: fix regression by BridgeAR · Pull Request #26912 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This fixes the parse function for single character input that are not
a path separator.
Fixes: #26911
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- tests and/or benchmarks are included
- documentation is changed or added
- commit message follows commit guidelines
Use destructuring and arrow functions and make one test stricter. Also inline the error object as there's only a sinlge error that can currently be thrown in the path module.
This fixes the parse function for single character input that are not a path separator.
Fixes: nodejs#26911
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
BridgeAR added a commit to BridgeAR/node that referenced this pull request
Use destructuring and arrow functions and make one test stricter. Also inline the error object as there's only a sinlge error that can currently be thrown in the path module.
PR-URL: nodejs#26912 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
BridgeAR added a commit to BridgeAR/node that referenced this pull request
This fixes the parse function for single character input that are not a path separator.
PR-URL: nodejs#26912 Fixes: nodejs#26911 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
targos pushed a commit that referenced this pull request
Use destructuring and arrow functions and make one test stricter. Also inline the error object as there's only a sinlge error that can currently be thrown in the path module.
PR-URL: #26912 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
targos pushed a commit that referenced this pull request
This fixes the parse function for single character input that are not a path separator.
PR-URL: #26912 Fixes: #26911 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
targos pushed a commit that referenced this pull request
Use destructuring and arrow functions and make one test stricter. Also inline the error object as there's only a sinlge error that can currently be thrown in the path module.
PR-URL: #26912 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
targos pushed a commit that referenced this pull request
This fixes the parse function for single character input that are not a path separator.
PR-URL: #26912 Fixes: #26911 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
targos pushed a commit that referenced this pull request
Use destructuring and arrow functions and make one test stricter. Also inline the error object as there's only a sinlge error that can currently be thrown in the path module.
PR-URL: #26912 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
targos pushed a commit that referenced this pull request
This fixes the parse function for single character input that are not a path separator.
PR-URL: #26912 Fixes: #26911 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
BethGriggs pushed a commit that referenced this pull request
Use destructuring and arrow functions and make one test stricter. Also inline the error object as there's only a sinlge error that can currently be thrown in the path module.
PR-URL: #26912 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
BethGriggs pushed a commit that referenced this pull request
This fixes the parse function for single character input that are not a path separator.
PR-URL: #26912 Fixes: #26911 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Michaël Zasso targos@protonmail.com
Labels
PRs that have at least one approval, no pending requests for changes, and a CI started.
Issues and PRs related to the path subsystem.