util: inspect() should not exceed breakLength by BridgeAR · Pull Request #26914 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Using util.inspect() with the compact option set to a number
could result in output that exceeded the breakLength option. This
change makes sure that limit is taken into account.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- tests and/or benchmarks are included
- documentation is changed or added
- commit message follows commit guidelines
Using util.inspect() with the compact option set to a number
could result in output that exceeded the breakLength option. This
change makes sure that limit is taken into account.
Issues and PRs related to the assert subsystem.
Issues and PRs related to the built-in util module.
labels
Issues and PRs related to the assert subsystem.
label
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BridgeAR added a commit to BridgeAR/node that referenced this pull request
Using util.inspect() with the compact option set to a number
could result in output that exceeded the breakLength option. This
change makes sure that limit is taken into account.
PR-URL: nodejs#26914 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com
BethGriggs pushed a commit that referenced this pull request
Using util.inspect() with the compact option set to a number
could result in output that exceeded the breakLength option. This
change makes sure that limit is taken into account.
PR-URL: #26914 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com
BethGriggs pushed a commit that referenced this pull request
Using util.inspect() with the compact option set to a number
could result in output that exceeded the breakLength option. This
change makes sure that limit is taken into account.
PR-URL: #26914 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
BethGriggs pushed a commit that referenced this pull request
Using util.inspect() with the compact option set to a number
could result in output that exceeded the breakLength option. This
change makes sure that limit is taken into account.
PR-URL: #26914 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
BethGriggs pushed a commit that referenced this pull request
Using util.inspect() with the compact option set to a number
could result in output that exceeded the breakLength option. This
change makes sure that limit is taken into account.
PR-URL: #26914 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Matteo Collina matteo.collina@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
Reviewers
Labels
PRs that have at least one approval, no pending requests for changes, and a CI started.
Issues and PRs related to the built-in util module.