net: remove usage of require('util') by dnlup · Pull Request #26920 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Use require('internal/util/inspect').inspect,
require('internal/util/debuglog').debuglog,
require('internal/util').deprecate and Object.setPrototypeOf instead
of require('util').
Fix test in test/parallel/test-net-access-byteswritten.js to do not
check the super_ property that was set when using
require('util').inherits.

Refs: #26546
Refs: #26896

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

dnlup mentioned this pull request

Mar 26, 2019

2 tasks

Use require('internal/util/inspect').inspect, require('internal/util/debuglog').debuglog, require('internal/util').deprecate and Object.setPrototypeOf instead of require('util'). Fix test in test/parallel/test-net-access-byteswritten.js to do not check the super_ property that was set when using require('util').inherits.

Refs: nodejs#26546 Refs: nodejs#26896

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 26, 2019

targos pushed a commit that referenced this pull request

Mar 30, 2019

Use require('internal/util/inspect').inspect, require('internal/util/debuglog').debuglog, require('internal/util').deprecate and Object.setPrototypeOf instead of require('util'). Fix test in test/parallel/test-net-access-byteswritten.js to do not check the super_ property that was set when using require('util').inherits.

Refs: #26546 Refs: #26896

PR-URL: #26920 Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Michaël Zasso targos@protonmail.com

I add the backport-requested label because the Object.setPrototypeOf part shouldn't land on v11.x.

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

Use require('internal/util/inspect').inspect, require('internal/util/debuglog').debuglog, require('internal/util').deprecate and Object.setPrototypeOf instead of require('util'). Fix test in test/parallel/test-net-access-byteswritten.js to do not check the super_ property that was set when using require('util').inherits.

Refs: #26546 Refs: #26896

PR-URL: #26920 Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Michaël Zasso targos@protonmail.com

This was referenced

Apr 23, 2019

dnlup deleted the util_net_test_fix branch

January 10, 2020 13:41

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

net

Issues and PRs related to the net subsystem.