util: add subclass and null prototype support for errors in inspect by BridgeAR · Pull Request #26923 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This adds support to visualize the difference between errors with
null prototype or subclassed errors. This has a couple safeguards
to be sure that the output is not intrusive.

We normally handle changed util.inspect() output as semver-patch
but in this case I'd say it's more like a semver-major even though I'd
love to get some early feedback. Any opinions about this?

CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1778/

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive.

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 26, 2019

No opinion on it really. I trust your judgement on it

targos pushed a commit that referenced this pull request

Mar 30, 2019

This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive.

PR-URL: #26923 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com

I added the do not land labels on this for v6-v10.

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive.

PR-URL: #26923 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com

BethGriggs pushed a commit that referenced this pull request

Apr 8, 2019

This adds support to visualize the difference between errors with null prototype or subclassed errors. This has a couple safeguards to be sure that the output is not intrusive.

PR-URL: #26923 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

BridgeAR deleted the improve-error-inspection-2 branch

January 20, 2020 11:57

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

util

Issues and PRs related to the built-in util module.