doc: remove "How is an LTS release cut?" section by Trott · Pull Request #26955 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The release process is in (or will soon be in) the Release repo, linked earlier in the doc.
Don't include information here because duplicated information is likely
to drift apart, resulting in contradictions and a lack of clarity about
which document is correct. (I think the text removed is already
out-of-date. I could be wrong, and it doesn't much matter, as it should
be removed anyway.) It's also not entirely clear what the
utility/relevance of this information is in this particular document.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes- documentation is changed or added
- commit message follows commit guidelines
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document.
vsemozhetbyt added the meta
Issues and PRs related to the general management of the project.
label
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the comment addressed.
There were two other sections that no longer exist that were still in the ToC. I've removed those as well.
Trott added the author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
targos pushed a commit to targos/node that referenced this pull request
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document.
PR-URL: nodejs#26955 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Luigi Pinca luigipinca@gmail.com
BethGriggs pushed a commit that referenced this pull request
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document.
PR-URL: #26955 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Luigi Pinca luigipinca@gmail.com
BethGriggs pushed a commit that referenced this pull request
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document.
PR-URL: #26955 Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
Trott deleted the how-is-cut branch
Reviewers
vsemozhetbyt vsemozhetbyt left review comments
apapirovski apapirovski approved these changes
lpinca lpinca approved these changes
targos targos approved these changes
BridgeAR BridgeAR approved these changes
Labels
PRs that have at least one approval, no pending requests for changes, and a CI started.
Issues and PRs related to the documentations.
Issues and PRs related to the general management of the project.