build,meta: tweak Travis config by refack · Pull Request #26969 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation21 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

@refack Sadly, an error occurred when I tried to trigger a build. :(

refack marked this pull request as ready for review

March 28, 2019 21:29

Reminder that if you're bumping the gcc version you may have to land in more than one commit to populate the ccache as I had to when we moved to gcc 6 (#26720 (comment)).

Reminder that if you're bumping the gcc version you may have to land in more than one commit

Mostly wanted to see if this builds faster. Since we might get in the same mess when we land V8 or change INCLUDES in common.gypi...

Travis builds are now timing out, which I suspect might be the recent V8 update 😢.

Ok first Travis job passed, so I cleared the cache and restarted.

refack added build

Issues and PRs related to build files or the CI.

script:
- PARALLEL_ARGS='--flaky-tests=skip' make -j1 test
- TEST_CI_ARGS="--flaky-tests=skip --report default" make -j1 V= test-ci

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the tap format used by test-ci Travis truncates the log in the web UI. e.g. https://travis-ci.com/nodejs/node/jobs/188985249 so you need to click through to the raw logs to see the full test results.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some grepping to get it down to ~6K lines

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 1, 2019

Ping @nodejs/build-files @nodejs/testing

Add lint-py-build to get lint-ci to lint python
Add compile V8 job
Make compilation verbose
Test with test-ci

PR-URL: nodejs#26969 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

Add lint-py-build to get lint-ci to lint python
Add compile V8 job
Make compilation verbose
Test with test-ci

PR-URL: #26969 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

refack deleted the travis-tweaks branch

April 7, 2019 15:01

BethGriggs pushed a commit that referenced this pull request

Apr 9, 2019

Add lint-py-build to get lint-ci to lint python
Add compile V8 job
Make compilation verbose
Test with test-ci

PR-URL: #26969 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

BethGriggs pushed a commit that referenced this pull request

Apr 9, 2019

Add lint-py-build to get lint-ci to lint python
Add compile V8 job
Make compilation verbose
Test with test-ci

PR-URL: #26969 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

BethGriggs pushed a commit that referenced this pull request

Apr 10, 2019

Add lint-py-build to get lint-ci to lint python
Add compile V8 job
Make compilation verbose
Test with test-ci

PR-URL: #26969 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Joyee Cheung joyeec9h3@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

build

Issues and PRs related to build files or the CI.