doc: add information about modules cache behavior by BridgeAR · Pull Request #26971 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

BridgeAR

This publicly documents that adding native module names will resolve
the added entry instead of the native module.

It also updates the description why extensions are deprecated.

Refs: #25362

Checklist

@BridgeAR

This publicly documents that adding native module names will resolve the added entry instead of the native module.

It also updates the description why extensions are deprecated.

@nodejs-github-bot

@BridgeAR Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added doc

Issues and PRs related to the documentations.

module

Issues and PRs related to the module subsystem.

labels

Mar 28, 2019

@BridgeAR

@nodejs/modules @nodejs/documentation PTAL

devsnek

@BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 28, 2019

sagirk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few nits! 🎉

vsemozhetbyt

@sagirk @BridgeAR

Co-Authored-By: BridgeAR ruben@bridgewater.de

@sagirk @BridgeAR

Co-Authored-By: BridgeAR ruben@bridgewater.de

@BridgeAR

@BridgeAR BridgeAR changed the titledocs: add information about modules cache behavior doc: add information about modules cache behavior

Mar 31, 2019

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Apr 1, 2019

@BridgeAR

This publicly documents that adding native module names will resolve the added entry instead of the native module.

It also updates the description why extensions are deprecated.

PR-URL: nodejs#26971 Refs: nodejs#25362 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com

@BridgeAR

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

@BridgeAR @BethGriggs

This publicly documents that adding native module names will resolve the added entry instead of the native module.

It also updates the description why extensions are deprecated.

PR-URL: #26971 Refs: #25362 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com

BethGriggs pushed a commit that referenced this pull request

Apr 9, 2019

@BridgeAR @BethGriggs

This publicly documents that adding native module names will resolve the added entry instead of the native module.

It also updates the description why extensions are deprecated.

PR-URL: #26971 Refs: #25362 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

BethGriggs pushed a commit that referenced this pull request

Apr 9, 2019

@BridgeAR @BethGriggs

This publicly documents that adding native module names will resolve the added entry instead of the native module.

It also updates the description why extensions are deprecated.

PR-URL: #26971 Refs: #25362 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

BethGriggs pushed a commit that referenced this pull request

Apr 10, 2019

@BridgeAR @BethGriggs

This publicly documents that adding native module names will resolve the added entry instead of the native module.

It also updates the description why extensions are deprecated.

PR-URL: #26971 Refs: #25362 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

doc

Issues and PRs related to the documentations.

module

Issues and PRs related to the module subsystem.