module: simpler esm loading by BridgeAR · Pull Request #26974 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This simplifies loading the experimental modules. Instead of always
checking for them we should eagerly load the functions in case the
experimental modules flag is passed through.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- tests and/or benchmarks are included
- documentation is changed or added
- commit message follows commit guidelines
This simplifies loading the experimental modules. Instead of always checking for them we should eagerly load the functions in case the experimental modules flag is passed through.
@BridgeAR Sadly, an error occurred when I tried to trigger a build. :(
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
BridgeAR added a commit to BridgeAR/node that referenced this pull request
This simplifies loading the experimental modules. Instead of always checking for them we should eagerly load the functions in case the experimental modules flag is passed through.
PR-URL: nodejs#26974 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Guy Bedford guybedford@gmail.com
BethGriggs pushed a commit that referenced this pull request
This simplifies loading the experimental modules. Instead of always checking for them we should eagerly load the functions in case the experimental modules flag is passed through.
PR-URL: #26974 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Guy Bedford guybedford@gmail.com
BethGriggs pushed a commit that referenced this pull request
This simplifies loading the experimental modules. Instead of always checking for them we should eagerly load the functions in case the experimental modules flag is passed through.
PR-URL: #26974 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Guy Bedford guybedford@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
BethGriggs pushed a commit that referenced this pull request
This simplifies loading the experimental modules. Instead of always checking for them we should eagerly load the functions in case the experimental modules flag is passed through.
PR-URL: #26974 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Guy Bedford guybedford@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
Labels
PRs that have at least one approval, no pending requests for changes, and a CI started.