Fix Travis builds by richardlau · Pull Request #27002 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Supersedes #26992 and incorporates #26968.
First commit:
build: add a `Prepare ccache` job in Travis
Combined compile and test of Node.js where lots of files need to be
compiled (e.g. after a V8 update) is exceeding the time limit for
Travis jobs (50 minutes).
Add a job to Travis that compiles Node.js but doesnt run any tests to
populate the ccache. Introduce staging and move the `Test Suite` job
into a later stage so that it can use the populated ccache.
Second commit:
build: fix skipping of flaky tests on Travis
`PARALLEL_ARGS` is overwritten in the Makefile if `JOBS` is set. Use
`CI_JS_SUITES` instead.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- commit message follows commit guidelines
Combined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes).
Add a job to Travis that compiles Node.js but doesnt run any tests to
populate the ccache. Introduce staging and move the Test Suite job
into a later stage so that it can use the populated ccache.
PARALLEL_ARGS is overwritten in the Makefile if JOBS is set. Use
CI_JS_SUITES instead.
This was referenced
Mar 30, 2019
Issues and PRs related to build files or the CI.
label
PRs that do not need to wait for 48 hours to land.
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Trott pushed a commit to Trott/io.js that referenced this pull request
Combined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes).
Add a job to Travis that compiles Node.js but doesnt run any tests to
populate the ccache. Introduce staging and move the Test Suite job
into a later stage so that it can use the populated ccache.
PR-URL: nodejs#27002 Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com
Trott pushed a commit to Trott/io.js that referenced this pull request
PARALLEL_ARGS is overwritten in the Makefile if JOBS is set. Use
CI_JS_SUITES instead.
PR-URL: nodejs#27002 Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com
Builds are now green again 🎉.
It should be safe to restart any timed out Travis pull request builds as they should pick up the refreshed ccache from the master builds.
@richardlau Why are we skipping flaky tests on Travis in the first place? Wouldn’t dontcare be better, like we do elsewhere in CI? I’ve personally made bad experiences with skipping tests in CI only, because that means that test suite is even more likely to fail for people locally…
@richardlau Why are we skipping flaky tests on Travis in the first place? Wouldn’t
dontcarebe better, like we do elsewhere in CI? I’ve personally made bad experiences with skipping tests in CI only, because that means that test suite is even more likely to fail for people locally…
¯\_(ツ)_/¯ Skipping flaky tests was introduced (albeit it wasn't working until this PR) in #23778. I have no objections to dontcare. cc @refack
I have no objections to
dontcare. cc @refack
Even with (Nope, that was removed in favor of tap/xunit parsing).dontcare the errorlevel is set to 2. Jenkins knows to interpret that as "Unstable", AFAICT Travis doesn't.
I'm leaning towards minimal sanity tests in Travis (which IMHO is not CI), I would actually be happy to cull even more test categories...
BethGriggs pushed a commit that referenced this pull request
Combined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes).
Add a job to Travis that compiles Node.js but doesnt run any tests to
populate the ccache. Introduce staging and move the Test Suite job
into a later stage so that it can use the populated ccache.
PR-URL: #27002 Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com
BethGriggs pushed a commit that referenced this pull request
PARALLEL_ARGS is overwritten in the Makefile if JOBS is set. Use
CI_JS_SUITES instead.
PR-URL: #27002 Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com
BethGriggs pushed a commit that referenced this pull request
Combined compile and test of Node.js where lots of files need to be compiled (e.g. after a V8 update) is exceeding the time limit for Travis jobs (50 minutes).
Add a job to Travis that compiles Node.js but doesnt run any tests to
populate the ccache. Introduce staging and move the Test Suite job
into a later stage so that it can use the populated ccache.
PR-URL: #27002 Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
BethGriggs pushed a commit that referenced this pull request
PARALLEL_ARGS is overwritten in the Makefile if JOBS is set. Use
CI_JS_SUITES instead.
PR-URL: #27002 Reviewed-By: Refael Ackermann refack@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Labels
Issues and PRs related to build files or the CI.
PRs that do not need to wait for 48 hours to land.