test: make module test pass with NODE_PENDING_DEPRECATION by addaleax · Pull Request #27019 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Some people set the NODE_PENDING_DEPRECATION environment variable
globally. This makes the test added in 115f0f5
pass when that is the case.

Refs: #26823

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Some people set the NODE_PENDING_DEPRECATION environment variable globally. This makes the test added in 115f0f5 pass when that is the case.

Refs: nodejs#26823

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZYSzys pushed a commit that referenced this pull request

Apr 3, 2019

Some people set the NODE_PENDING_DEPRECATION environment variable globally. This makes the test added in 115f0f5 pass when that is the case.

Refs: #26823

PR-URL: #27019 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Myles Borins myles.borins@gmail.com

addaleax deleted the test-module-loader-pending branch

April 3, 2019 13:59

BethGriggs pushed a commit that referenced this pull request

Apr 4, 2019

Some people set the NODE_PENDING_DEPRECATION environment variable globally. This makes the test added in 115f0f5 pass when that is the case.

Refs: #26823

BethGriggs pushed a commit that referenced this pull request

Apr 9, 2019

Some people set the NODE_PENDING_DEPRECATION environment variable globally. This makes the test added in 115f0f5 pass when that is the case.

Refs: #26823

BethGriggs pushed a commit that referenced this pull request

Apr 10, 2019

Some people set the NODE_PENDING_DEPRECATION environment variable globally. This makes the test added in 115f0f5 pass when that is the case.

Refs: #26823

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

test

Issues and PRs related to the tests.