test: fix error code typo by cjihrig · Pull Request #27024 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- tests and/or benchmarks are included
- commit message follows commit guidelines
Looks like this is not just a typo fix. Pushed up other fixes.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing my multiple mistakes with this.
Seems like a candidate for fast-tracking? 👍 if you're a Collaborator and agree.
PRs that do not need to wait for 48 hours to land.
label
danbev pushed a commit that referenced this pull request
PR-URL: #27024 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Luigi Pinca luigipinca@gmail.com
BethGriggs pushed a commit that referenced this pull request
PR-URL: #27024 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Luigi Pinca luigipinca@gmail.com
BethGriggs pushed a commit that referenced this pull request
PR-URL: #27024 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Luigi Pinca luigipinca@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
BethGriggs pushed a commit that referenced this pull request
PR-URL: #27024 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Luigi Pinca luigipinca@gmail.com Signed-off-by: Beth Griggs Bethany.Griggs@uk.ibm.com
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request
PR-URL: nodejs#27024 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Luigi Pinca luigipinca@gmail.com
MylesBorins pushed a commit that referenced this pull request
Backport-PR-URL: #27776 PR-URL: #27024 Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Anatoli Papirovski apapirovski@mac.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Luigi Pinca luigipinca@gmail.com
This was referenced
May 29, 2019
Reviewers
Labels
PRs that do not need to wait for 48 hours to land.
Issues and PRs related to the tests.